Opened 12 years ago

Closed 11 years ago

#2879 closed defect (fixed)

KYRA1: Brandon standing IN the floor

Reported by: (none) Owned by: athrxx
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 1

Description

ScummVM 0.10.0svn (Oct 22 2006 23:53:52)
Features compiled in: Vorbis FLAC MP3 zLib MPEG2

Little gfx glitch:
Brandon is walking and standing IN the floor of
the caverns, at least there i took a grab.

Kyrandia English DOS (Talkie)

AmigaOS4
gcc version 4.0.2 (AmigaOS build 20051012)

Ticket imported from: #1582675. Ticket imported from: bugs/2879.

Attachments (3)

Grab.jpg (3.5 KB) - added by SF/*anonymous 12 years ago.
Standing IN the floor
scaler_original.png (23.8 KB) - added by lordhoto 12 years ago.
original scaler
scaler_scummvm.png (36.5 KB) - added by lordhoto 12 years ago.
scummvm scaler

Download all attachments as: .zip

Change History (15)

Changed 12 years ago by SF/*anonymous

Attachment: Grab.jpg added

Standing IN the floor

comment:1 Changed 12 years ago by (none)

That goes for the screen before Zanthia's
place (in the marsh) and the screen before
the castle entrance "A high bluff", too.

comment:2 Changed 12 years ago by (none)

Also affected are the "royal hallways" (except
the one where Herman is) and the "dank, dungeon
passages" PLUS the upper half of the "royal
chamber" which is strange because the lower
half is allright

comment:3 Changed 12 years ago by lordhoto

Yeah it's a problem with the scaling of Brandon it seems. So it should occur in all places where Brandon is scaled.

comment:4 Changed 12 years ago by lordhoto

Owner: set to lordhoto

Changed 12 years ago by lordhoto

Attachment: scaler_original.png added

original scaler

comment:5 Changed 12 years ago by lordhoto

I compared it to the original today and it seems even in the original he stands 'in' the floor.
I attached two screenshots, one of the original game and one of ScummVM, as you can see the original
scaler looks nicer, but also makes the feet partially missing.
File Added: scaler_original.png

Changed 12 years ago by lordhoto

Attachment: scaler_scummvm.png added

scummvm scaler

comment:6 Changed 12 years ago by lordhoto

File Added: scaler_scummvm.png

comment:7 Changed 12 years ago by sev-

LordHoto, do you think this script bug could be fixed in ScummVM? If not, then perhaps this bugreport should be closed?

comment:8 Changed 12 years ago by lordhoto

Just an graphics 'glitch', because of an different scaler than used in the original, I'll look at changing our scaler a bit then.

comment:9 Changed 11 years ago by sev-

What is the status of this item?

comment:10 Changed 11 years ago by lordhoto

I compared our version with disassembly and it looks quite different, the original version looks much more complicated, so I would have to rewrite our scaler (our current implementation is pretty simple, check engines/kyra/screen.cpp ll1317-1334), since I am low on time currently I do not think it will happen anytime soon, also since it is a palette based graphics format I guess a scaler giving nice results would need some work. But apart from that I do not think the graphics glitch is that bad.

comment:11 Changed 11 years ago by athrxx

Owner: changed from lordhoto to athrxx
Resolution: fixed
Status: newclosed

comment:12 Changed 11 years ago by athrxx

I just implemented the orginal scaling code. Should look much better now.

Note: See TracTickets for help on using tickets.