Opened 13 years ago

Closed 13 years ago

Last modified 16 months ago

#2812 closed defect (fixed)

SMUSH: changing subtitle settings during SMUSH doesn't work

Reported by: salty-horse Owned by: sev-
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

Using current svn.

SMUSH videos only check the subtitle setting on startup. If they are changed while the video is playing, SMUSH will act as if no change took place.

To test, start up Full Throttle with the subtitles off, then change the setting while the intro is running. The subtitles will only appear when the intro ends.

Ticket imported from: #1550974. Ticket imported from: bugs/2812.

Change History (8)

comment:1 by fingolfin, 13 years ago

Summary: SCUMM: changing subtitle settings during SMUSH doesn't workSMUSH: changing subtitle settings during SMUSH doesn't work

comment:2 by sev-, 13 years ago

There is no way to implemet that. In SMUSH movies text is an attribute of each frame. I.e. some frames have text drawn on them, and some don't and each phrase is drawn predefined number of frames. Only way to make text slower is to slow down whole video, including audio.

Of course, same applies to original.

comment:3 by sev-, 13 years ago

Owner: set to sev-
Resolution: invalid
Status: newclosed

comment:4 by salty-horse, 13 years ago

Resolution: invalid
Status: closednew

comment:5 by salty-horse, 13 years ago

I understand that the text speed in smush movies is constant (as it should be, same for all the talkies).

The bug refers to whether or not the subtitles are displayed at all. I think the only thing missing is to add a check for the subtitles mode before the drawing of each frame, instead of just init().

comment:6 by sev-, 13 years ago

Resolution: fixed
Status: newclosed

comment:7 by sev-, 13 years ago

That makes difference. Fixed in SVN and backported

comment:8 by digitall, 16 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.