Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#2780 closed defect (fixed)

SIMON1 (French): Text wrongly displayed

Reported by: SF/hibernatus Owned by: Kirben
Priority: high Component: Engine: AGOS
Keywords: original Cc:
Game: Simon the Sorcerer 1

Description

Look at the screenshot.
Line 3 (C'etait delicieux...) contains whitespaces at
the end which make it take 2 lines instead of one.

Ticket imported from: #1538873. Ticket imported from: bugs/2780.

Attachments (1)

Spaces.gif (45.6 KB ) - added by SF/hibernatus 13 years ago.
Line 4 is wrongly displayed because of whitespaces at the end of line 3

Download all attachments as: .zip

Change History (22)

by SF/hibernatus, 13 years ago

Attachment: Spaces.gif added

Line 4 is wrongly displayed because of whitespaces at the end of line 3

comment:1 by Kirben, 13 years ago

Owner: set to Kirben

comment:2 by Kirben, 13 years ago

I think these text related bugs, occured in the original
French version too.

It would be helpful if you could try the game under dosbox,
to confirm if the issue occurs in the original game too.

You can use the saved game from ScummVM. in the original
game too. You will just need to unpack (They are gzip
compressed) and rename the filenames of the saved games.

comment:3 by SF/hibernatus, 13 years ago

Ah, you're right. Sorry.
It's strange, because it's only because of the trailing
whitespaces, so i thought the original engine would remove
them, but it doesn't.

comment:4 by fingolfin, 13 years ago

Status: newpending
Summary: Simon1: Text wrongly displayedSIMON1: Text wrongly displayed

comment:5 by fingolfin, 13 years ago

Can this be closed then?

comment:6 by Kirben, 13 years ago

Status: pendingnew
Summary: SIMON1: Text wrongly displayedSIMON1 (French): Text wrongly displayed

comment:7 by Kirben, 13 years ago

A work around might be possible, but I don't have the
French version of Simon the Sorcerer 1 myself.

comment:8 by fingolfin, 13 years ago

Owner: changed from Kirben to eriktorbjorn

comment:9 by fingolfin, 13 years ago

Couldn't you try to implement a workaround, then ask hibernatus to check
whether it works?

For example, one could just alway strip trailing whitespaces when printing
text. Or is that likely to cause regressions? If so, it shouldn't be too hard to
only perform this for specific texts... ?

I would try to do this, but I am not very familiar with the Simon/AGOS engine,
so it'd probably be done quicker if Kirben could try it. Or maybe Torbjörn is
interested in looking into this?

comment:10 by eriktorbjorn, 13 years ago

I don't know whether or not it'd cause regressions. I'm not
all that familiar with the AGOS engine.

I believe all those conversation messages go through
showMessageFormat(), but there are other things that do as well.

comment:11 by SF/hibernatus, 13 years ago

It could cause a regression if a translation uses that
"feature" to position sentences in front of numbers instead
of numbers in front of sentences.

For example:
1 Blah blah...
...blah?
2 Blah blah?

translated to:
1 Bla bla... bla?
<- blank line
2 Bla bla?

I've never seen that in the french version.

I don't see any other reason for a regression.

Here is a little tool which would help finding all the
concerned sentences in every translation.
http://hibernatus34.free.fr/simon/SimonTR.exe
(windows only)

comment:12 by bluegr, 13 years ago

Is it possible that this bug has been fixed with change #25807 ?

comment:13 by Kirben, 13 years ago

No, that change was unrelated.

comment:14 by Kirben, 12 years ago

Could you please try the dump all subroutines option, in the next snapshot of ScummVM SVN, and attach a file of the output.

Start ScummVM via command line, with output redirected to a file. ie:
scummvm simon1 > simon1fr.txt

Wait for the game to be displayed.
Press 'CTRL u' to dump all subroutines.
Wait a minute or two for output to complete.
Quit ScummVM.

Then just attached the file 'simon1fr.txt', to this bug report.

The output should make it much easier to attempt a work around, based on the specific strings where it occurs.

comment:15 by SF/richiefs, 12 years ago

Here are the requested data:
http://dl.free.fr/izbLY2oYy/simon1fr.txt

comment:16 by sev-, 11 years ago

What is the status of this item?

comment:17 by sev-, 10 years ago

This bug is nice to get fixed before the release. Raising priority for keeping the track.

comment:18 by sev-, 10 years ago

Owner: changed from eriktorbjorn to Kirben
Priority: normalhigh

comment:19 by Kirben, 10 years ago

Keywords: original added
Resolution: fixed
Status: newclosed

comment:20 by Kirben, 10 years ago

Fixed in ScummVM SVN, use the next daily snapshot of ScummVM SVN.

comment:21 by Kirben, 10 years ago

For future reference:
This problem effects the Polish version of Simon the Sorcerer 2 too.

Note: See TracTickets for help on using tickets.