Opened 14 years ago

Closed 14 years ago

Last modified 11 years ago

#2455 closed defect (fixed)

GOB1: Invalid reads during startupy

Reported by: Kirben Owned by: DrMcCoy
Priority: normal Component: Engine: Gob
Keywords: Cc:
Game: Gobliiins

Description

Using latest ScummVM 0.9.0 CVS. Compiled with GCC 3.3.6, under Topologilinux 6.0.0. CD version of Gobliins (English).

Valgrind reports several invalid reads when loading palette, as Gobliins starts up. See the attached log.

Ticket imported from: #1402511. Ticket imported from: bugs/2455.

Attachments (1)

gob1.txt (14.3 KB ) - added by Kirben 14 years ago.
Valgrind log

Download all attachments as: .zip

Change History (6)

by Kirben, 14 years ago

Attachment: gob1.txt added

Valgrind log

comment:1 by Kirben, 14 years ago

Summary: GOB1: Ivalid read during startupGOB1: Invalid reads during startup

comment:2 by eriktorbjorn, 14 years ago

Looks like the one I was telling sev about yesterday, where setFullPalette() is called (I believe) on the 16-colour _vgaPalette[] in gob/global.h.

I don't know enough about the Goblins engine to fix it. At least not at this time.

comment:3 by DrMcCoy, 14 years ago

Status: newclosed
Summary: GOB1: Invalid reads during startupGOB1: Invalid reads during startupy

comment:4 by DrMcCoy, 14 years ago

There are actually two _vgaPalette[]s, one in gob/global.h and one in gob/draw.h, when I wrapped the whole code into classes, I assumed the one in gob/init.cpp to be the wrong one, I guess... Should be fixed now...

comment:5 by Kirben, 11 years ago

Owner: set to DrMcCoy
Resolution: fixed
Note: See TracTickets for help on using tickets.