Opened 18 years ago

Closed 18 years ago

#2399 closed defect (fixed)

ITE: White Noise instead of Music Playback

Reported by: (none) Owned by: SF/h00ligan
Priority: normal Component: Engine: SAGA
Version: Keywords:
Cc: Game: Inherit the Earth

Description

I get a massive "white" noise as soon as sound output starts. I can hear the narrator talking (very low), but cannot make out music, but that could easily be due to the noise.

Summarized from the forums:

° Platform: AmigaOS4 ° Big Endian problem? ° Wyrmkeep Re-Release #4?

Ticket imported from: #1374198. Ticket imported from: bugs/2399.

Change History (6)

comment:1 by (none), 18 years ago

Summary: White Noise instead of Music PlaybackITE: White Noise instead of Music Playback

comment:2 by fuzzie, 18 years ago

I get this issue on Linux/PPC with the downloadable ITE demo.

comment:3 by eriktorbjorn, 18 years ago

That could be an error in RAWInputStream::refill(), though if so it's strange that no one has reported it until now.

If memory serves me, it's supposed to fill the buffer with samples in native byte order. It looks like it's always filling it with little-endian samples. So instead of

if (_context->isBigEndian) {

perhaps it ought to be

#if defined(SCUMM_LITTLE_ENDIAN) if (_context->isBigEndian) { #else if (!_context->isBigEndian) { #endif

or something to that effect. But I don't have access to any big-endian computer (unless you count the Mac Plus in my closet, which would be useless to test this with anyway), so I can't verify this.

comment:4 by fuzzie, 18 years ago

That pretty much works. The patch at http://fuzzie.org/ite_music.patch seems to work on both big and little endian machines here.

comment:5 by SF/h00ligan, 18 years ago

Owner: set to SF/h00ligan
Resolution: fixed
Status: newclosed

comment:6 by SF/h00ligan, 18 years ago

fixed in CVS

Note: See TracTickets for help on using tickets.