Opened 15 years ago

Closed 15 years ago

#2209 closed defect (fixed)

ITE: Game detection is broken

Reported by: eriktorbjorn Owned by: sev-
Priority: high Component: Engine: SAGA
Keywords: Cc:
Game: Inherit the Earth

Description

The game detection for ITE is quite broken at the moment. We simply cannot tell the difference between the various versions. For instance, if I copy the files from my Linux CD version (since the game detector cannot detect the game directly from CD) and try to add it, I'm presented with the following choices:

Inherit the Earth (Linux CD Version) Inherit the Earth (Win32 CD Version) Inherit the Earth (DOS/Win32 CD Version)

While I can select that this is the Linux version, this information is not saved in the config file except as a game description. At run-time, it will simply pick one. And it probably picks the wrong one, since the game crashes with a "RAWInputStream() wrong musicInfo!" message.

My Windows version is is identified as either:

Inherit the Earth (Win32 CD Version) Inherit the Earth (DOS/Win32 CD Version)

I have a nagging feeling that it's mis-identified at run-time, because there are glitches with the WyrmKeep logo animation. I'll see if I can look into that later. It's outside the scope of this bug report.

My Multi-OS version is correctly identified, but plain refuses to run. I'm returned to the launcher with no error message. I'll see if I can look into that later, as well. It, too, is outside the scope of this bug report.

Ticket imported from: #1297365. Ticket imported from: bugs/2209.

Change History (8)

comment:1 by eriktorbjorn, 15 years ago

Owner: set to sev-

comment:2 by eriktorbjorn, 15 years ago

Hmm... The Windows version is identified as a WyrmKeep version at run-time, so the animation glitch might be a regression.

comment:3 by eriktorbjorn, 15 years ago

I believe I have fixed the Linux and multi-CD versions now, by setting the correct music and voice info for them. The logo animation is still glitchy for all three of them, though.

I'd still say game detection is broken, but not nearly as badly as I first thought.

comment:4 by eriktorbjorn, 15 years ago

As a side note, the intro animation glitch now has its own bug report, #1298659. I've managed to track down when it was introduced, but I don't know enough about it to fix it.

comment:5 by sev-, 15 years ago

Raising priority. This is release critical.

comment:6 by sev-, 15 years ago

Priority: normalhigh

comment:7 by sev-, 15 years ago

Resolution: fixed
Status: newclosed

comment:8 by sev-, 15 years ago

Phew. Finally fixed it. Now it distinguishes between them, though it uses platform and language settings from .ini to do the choice. I.e current games need to be redetected. Though only these 2 games are affected. I.e. they have exactly same resource filess, just Windows release adds up external patches. These patches cannot be added to detection as they're stored in subdirectories.

Also I resolved problem between ite-demo-win and ite-demo-linux where latter is a superset of former. I.e. it has all files which win demo has plus one additional. And if you try to detect Linux demo it shows you both. Of course this could be handled by upper solution, but to make sure I count number of required files for matched versions and remove those which do not have max number of files. I.e. if 2 games matched and one requires 4 and another one requires 5 files, then we have 5 files matched which certainly points to second game not the first.

Note: See TracTickets for help on using tickets.