Opened 19 years ago

Closed 19 years ago

#2158 closed defect (fixed)

ITE: NonActorsSpeech does not lock thread

Reported by: sev- Owned by: eriktorbjorn
Priority: low Component: Engine: SAGA
Version: Keywords:
Cc: Game: Inherit the Earth

Description

In Puzzle when masters try to give hints to Rif, speech and subtitles geto verlapped instead of being shown/heard sequentally. Especially it is noticeable when Sakka denies hint.

To reproduce load attached savegame, talk to Sakka and choose "Bring on your test". Then start to putting puzzle together but make one mistake. In about 20 seconds you will be offered a hint, it is random process, and you should agree with hint each time but do nothing untill you will hear how Sakka denies.

ITE version: Any but most noticeable is talkie ScummVM: CVS August 16 Platform: any

Ticket imported from: #1260904. Ticket imported from: bugs/2158.

Attachments (2)

ite-cd-mac.s06​ (3.8 KB ) - added by sev- 19 years ago.
Savegame at guild
ite-puzzle.diff​ (2.1 KB ) - added by eriktorbjorn 19 years ago.
Patch against an October 1 CVS snapshot

Download all attachments as: .zip

Change History (5)

by sev-, 19 years ago

Attachment: ite-cd-mac.s06​ added

Savegame at guild

comment:1 by eriktorbjorn, 19 years ago

Would thread locking work for this, though? I thought the puzzle existed more or less outside of the rest of the game logic.

I'm attaching a possible fix for the problem that introduces a new "speaking" puzzle state, which does nothing except check if the speech has finished and, if it has, advances to the next state.

by eriktorbjorn, 19 years ago

Attachment: ite-puzzle.diff​ added

Patch against an October 1 CVS snapshot

comment:2 by eriktorbjorn, 19 years ago

Owner: set to eriktorbjorn
Resolution: → fixed
Status: new → closed

comment:3 by eriktorbjorn, 19 years ago

I've applied my patch. Closing.

Note: See TracTickets for help on using tickets.