Opened 15 years ago

Closed 15 years ago

Last modified 19 months ago

#1909 closed defect

Possible mistake in ImuseDigiSndMgr::getDataFromRegion()

Reported by: eriktorbjorn Owned by: aquadran
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

I'm getting the following warnings when compiling the latest CVS snapshot:

scumm/imuse_digi/dimuse_sndmgr.cpp: In member function `int32

Scumm::ImuseDigiSndMgr::getDataFromRegion(Scumm::ImuseDigiSndMgr::soundStruct*, int, byte**, int, int)': scumm/imuse_digi/dimuse_sndmgr.cpp:568: warning: declaration of `offset' shadows a parameter scumm/imuse_digi/dimuse_sndmgr.cpp:538: warning: shadowed declaration is here scumm/imuse_digi/dimuse_sndmgr.cpp:568: warning: declaration of `size' shadows a parameter scumm/imuse_digi/dimuse_sndmgr.cpp:538: warning: shadowed declaration is here

I don't dare to fix this myself since I don't currently have the means to test it, not to mention that my knowledge of this part of the code is limited to say the least.

Ticket imported from: #1110622. Ticket imported from: bugs/1909.

Change History (5)

comment:1 by eriktorbjorn, 15 years ago

Owner: set to aquadran

comment:2 by aquadran, 15 years ago

it doesn't matter, but i 'll change 'offset' to 'offs' to prevent compiler warning.

comment:3 by aquadran, 15 years ago

Status: newclosed

comment:4 by eriktorbjorn, 15 years ago

That fixes the shadowing of "offset", sure, but I was actually more worried about the shadowing of "size" since there are references to "size" after that block of code.

comment:5 by digitall, 19 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.