Opened 16 years ago

Closed 16 years ago

Last modified 2 years ago

#1781 closed defect (fixed)

SCUMM: Inalid read/writes in Gdi::drawStripToScreen

Reported by: Kirben Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Day of the Tentacle

Description

Latest ScummVM cvs version. English version of Day of the Tentacle CD. Compiled under mingw with GCC 3.4.1 and running under Windows XP.

I noticed ScummVM seemed more unstable today, so tried running under Valgrind and noticed several invalid read/writes in Gdi::drawStripToScreen(). I have attached valgrind log from Day of the Tentacle but this issue could effect all SCUMM games.

Ticket imported from: #1034519. Ticket imported from: bugs/1781.

Attachments (2)

invalid.txt (7.8 KB ) - added by Kirben 16 years ago.
Valgrind log
comi.txt (5.5 KB ) - added by Kirben 16 years ago.
COMI Valgrind log

Download all attachments as: .zip

Change History (12)

by Kirben, 16 years ago

Attachment: invalid.txt added

Valgrind log

comment:1 by SF/kaminari, 16 years ago

May be related to the smooth scrolling hack.

I noticed that The Dig and Full Throttle are extremely unstable, they won't start 3 times out of 5 or would crash unexpectedly during a dialogue, a room change, whatever. I also noticed the parallax scrolling in The Dig (the Museum for example) produces a kind of 'mask smearing' in the background which I can't quite describe, even with a screenshot. I only have a savestate for the French Mac version, probably not very useful.

The sad thing is, I don't even get any error message at all :-(

comment:2 by fingolfin, 16 years ago

Status: newclosed

comment:3 by fingolfin, 16 years ago

yeah, of course it's from the smooth scrolling hack. Nothing to worry about, I just disabled it again -- an email telling me about the issues would've been sufficient, really :-)

by Kirben, 16 years ago

Attachment: comi.txt added

COMI Valgrind log

comment:4 by Kirben, 16 years ago

I'm still noticing some invalid read/writes, even with smooth scrolling disabled. Attached Valgrind log from COMI this time.

comment:5 by Kirben, 16 years ago

Status: closednew

comment:6 by eriktorbjorn, 16 years ago

Status: newclosed

comment:7 by eriktorbjorn, 16 years ago

Resolution: fixed

comment:8 by eriktorbjorn, 16 years ago

I ran into the same problem yesterday night. Seems the real culprit was the bit where it checks it limits 'width' to vs->width or less. I've changed it to vs->w - x or less instead. It seems to work now.

comment:9 by fingolfin, 16 years ago

Owner: changed from fingolfin to eriktorbjorn

comment:10 by digitall, 2 years ago

Component: --Unset--Engine: SCUMM
Game: Day of the Tentacle
Note: See TracTickets for help on using tickets.