Opened 16 years ago

Closed 16 years ago

#1738 closed defect (fixed)

LOOM: Cursor hotspot is wrong (regression)

Reported by: sev- Owned by: eriktorbjorn
Priority: high Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

With latest Fingolfin's cursor improvement cursor hotspot in Loom is shifted in down-right direction, i.e. intead of (0,0) it somewhere around (10,11).

Steps to reproduce: Start the game and try to point on the leaf.

ScummVM version: CVS Aug 23.

Ticket imported from: #1014296. Ticket imported from: bugs/1738.

Attachments (1)

loom_cursor_fix.diff (1.9 KB ) - added by eriktorbjorn 16 years ago.
Patch against an August 23 CVS snapshot

Download all attachments as: .zip

Change History (6)

comment:1 by sev-, 16 years ago

Owner: set to fingolfin
Priority: normalhigh

by eriktorbjorn, 16 years ago

Attachment: loom_cursor_fix.diff added

Patch against an August 23 CVS snapshot

comment:2 by eriktorbjorn, 16 years ago

A bug in our "set hotspot" opcode, it seems: it ignores the 'index' parameter. I've attached a possible patch, but I'm a bit uncertain about which games need the three-parameter version of setCursorHotspot(), so I'm hesitant to apply it.

comment:3 by fingolfin, 16 years ago

It should be for all V3-V5 games, I'd say. Those games had 4 basic cursor, which could be set via SO_CURSOR_SET; and SO_CURSOR_IMAGE / SO_CURSOR_HOTSPOT modified these built-in cursors. In newer games, the cursors are far more flexible, so the hotspot/image etc. are simply set for the current/active cursor.

comment:4 by eriktorbjorn, 16 years ago

Ok, I've modified my patch a bit to make it more consistent with how the cursor images are redefined, and comitted it.

Even in a worst case, it shouldn't be able to cause much harm. :-)

comment:5 by eriktorbjorn, 16 years ago

Owner: changed from fingolfin to eriktorbjorn
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.