Opened 15 years ago

Closed 15 years ago

#1723 closed defect (fixed)

LAUNCHER: Doesn't distinguish monkey and monkey1

Reported by: SF/manny182 Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 1

Description

When adding the alt monkey island cd, it used id:
monkey, instead of id: monkey1.

This resulted in serching for monkey.000 file, instead of
a monkey1.000 file, therefor not working to a user who
doesn't know how to change id's.

It's also gives you the wrong description too, well that
was obvious.

I tried it with copied onto the hardrive with extra mp3
audio rips, as well as directly from the cd.

Hope you can fix this very soon.

thnx in advance manny182

Ticket imported from: #1009344. Ticket imported from: bugs/1723.

Change History (10)

comment:1 by fingolfin, 15 years ago

There was a bug in the internal MD5 DB (essentially, some checksum
were duplicate).
We need more information from you in order to properly process this
item, though. Like the MD5 checksum of your monkey1.000 file :-). And
the version of ScummVM you are using. And what OS you are on...

comment:2 by fingolfin, 15 years ago

Owner: set to fingolfin

comment:3 by fingolfin, 15 years ago

Summary: Won't tell the different between alt cd and other cdLAUNCHER: Doesn't distinguish monkey and monkey1

comment:4 by SF/manny182, 15 years ago

Ok well i never have done a checksum before, but
downloaded a utility at www.fastsum.com, and got these
results: MONKEY1.000 2D1E891FE52DF707C30185E52C50CD92
and MONKEY1.001 D074150DE681D49FF350E8AD60EE4ABD

I'm on win xp pro, and scummvm using the latest version:
0.6.1b

comment:5 by SF/manny182, 15 years ago

oops' i acidently overwrote the first post, well there are the
results.

comment:6 by fingolfin, 15 years ago

Interesting. Seems like the same MD5 is used for both the "monkey" and
"monkey1" targets...

The best solution I can think of right now would be to add some code
which automatically makes ScummVM fallback to "monkey1" if "monkey"
isn't found...

comment:7 by SF/manny182, 15 years ago

wow i'm quite happy i found a bug, and a relatively
simple one too.

i just put the right one in the scummvm manually.

but using you method will not give the right description.

what i suggest for that game only, is do the MD5
checksum to find out it's one of the two, then check the
filename (monkey.000 or monkey1.000) when registering
it, so you get the right description.

By what i understand, your saying to check after it's
been put on the menu, which would work, but won't say
(alt) next to it.

Sorry for being so fussy, i thought it would make
scummvm go more to it's objective of being bug free, it's
only suggestion, and remember your the programmer,
and i'm just a simpleton thats grateful for such a
program. ;)

comment:8 by SF/manny182, 15 years ago

Also sorry about the other thread, it was meant to be a
followup for this one.

I haven't got use to the forum yet, when it said login and
post, i thought it meant a post reply, not to start a new
thread.

comment:9 by fingolfin, 15 years ago

Resolution: fixed
Status: newclosed

comment:10 by fingolfin, 15 years ago

Added a workaround to CVS.

Note: See TracTickets for help on using tickets.