Opened 16 years ago

Closed 10 years ago

#1683 closed defect (fixed)

MI2 FM-TOWNS: Purple, Intro Credits

Reported by: SF/risskin Owned by: athrxx
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

Hi,

I have noticed that in the English FM Towns Version of Monkey Island 2, a great part of the inventory/commando area is "very purple" - just pick up a sheet of paper at Wally's and you'll see what I mean. Also, when the commandos/inventory disappear (e.g. when Guybrush is in a conversation or is rowing through the swamp), there is a purple box in the left part of the lower screen area (in a conversation, it becomes black once you hit the dialogue lines with the mouse cursor).

Another thing I've noticed is that in the intro of the game, the credits won't disappear - i.e. new text lines are simply drawn _over_ the old ones, which results in a mess of letters on the screen.

Did anybody else have these problems? Any further bugs in later parts of the game (I'mm still in Part one)?

Best wishes and many thanks for this great software! You're doing an incresible job! Matthias.

P.S.: Oh, and I could add some screen shots later if you wish. Is there a way to make them directly with ScummVM (maybe a hotkey or some command?)

Ticket imported from: #996407. Ticket imported from: bugs/1683.

Attachments (6)

mi2fm1.jpg (71.8 KB ) - added by fingolfin 14 years ago.
Screenshot ScummVM English MI2, first room
mi2fm2.jpg (37.3 KB ) - added by fingolfin 14 years ago.
Screenshot ScummVM English MI2, credits
dumps.zip (41.6 KB ) - added by fingolfin 14 years ago.
Script dumps
monkey2fmt_02a.png (69.7 KB ) - added by fingolfin 14 years ago.
Screenshot Unz Japanese MI2, first room
monkey2fmt_02b.png (70.3 KB ) - added by fingolfin 14 years ago.
Screenshot ScummVM Japanese MI2, first room
monkey2fmt_03.png (19.5 KB ) - added by fingolfin 14 years ago.
Screenshot ScummVM English MI2, credits

Download all attachments as: .zip

Change History (35)

comment:1 by fingolfin, 16 years ago

Priority: normallow
Summary: Monkey2Towns: Purple (like LoomTowns), Intro CreditsMONKEY2 FMTOWNS: Purple, Intro Credits

comment:2 by fingolfin, 16 years ago

You can press Alt-s to produce a screenshot

comment:3 by fingolfin, 16 years ago

Summary: MONKEY2 FMTOWNS: Purple, Intro CreditsMI2 FMTOWNS: Purple, Intro Credits

comment:4 by SF/mbandsmer, 16 years ago

I've observed these problems too. (Credits not disappearing, purple backgrounds in inventory, and purple box during conversations).

comment:5 by SF/grimdusk, 16 years ago

I also noticed this happening in the FM Towns version. Not sure if this has any relevance, but in the background information window it would occasionally display the message "WARNING: Unknown screen effect, 30!".

I'll attach a couple screenshots.

comment:6 by SF/grimdusk, 16 years ago

Not sure how to attach files here on Sourceforge. Here are links to the images on an external site:

http://img29.exs.cx/img29/7872/mi2fm1.jpg http://img29.exs.cx/img29/4223/mi2fm2.jpg

comment:7 by Kirben, 16 years ago

The Amiga version of Monkey Island 2 just used a different VAR_VIDEOMODE value to set palette differences, I wonder if this could be another case. Could you dump the scripts (Just through introduction, until game is playable) from the game and attach a compressed file of the *.dmps to bug report ?

comment:8 by SF/grimdusk, 16 years ago

Here you go:

http://members.cox.net/myfilez/dumps.zip

comment:9 by Kirben, 16 years ago

Owner: set to Kirben

comment:10 by Kirben, 16 years ago

It looks like the FM Towns version uses a VAR_VIDEOMODE setting of 42. The change is included in current Windows snapshot and will be included in next daily snapshot for other systems. Or if you compile ScummVM yourself, try changing VAR_VIDEOMODE value to 42 at line 1370 of scumm/scumm.cpp.

Let me know if that helps.

comment:11 by SF/grimdusk, 16 years ago

Just tested it with the Win32 Daily Snapshot dated (Aug 21st 2004 11:41:56) and it didnt appear to be fixed. Maybe this wasn't the one you are referring to, so i'll try it again on the next build.

comment:12 by Kirben, 16 years ago

I updated Windows snapshot again, the FM Towns platform was not been set correctly. Please try again with updated Windows snapshot. Make sure platform is to to FM-TOWNS for this game.

comment:13 by SF/kaminari, 16 years ago

The credits are still corrupted with the latest Win32 CVS (1496K exe file, last update: August 22, 2004, 2:33 am). See for yourself:

http://namida.com/kaminarimon/tmp/monkey2fmt_03.png

This is an interesting thread. In the FM-Towns version, the intro credits as well as the inventory verbs are not supposed to be purple as in the VGA version; they're actually light brown (for both Japanese and English languages).

Unz: http://namida.com/kaminarimon/tmp/monkey2fmt_02a.png

ScummVM: http://namida.com/kaminarimon/tmp/monkey2fmt_02b.png

Btw, I suppose the messed up kanjis in ScummVM are due to the fact that it doesn't use a 640x480 overlay for the Japanese font. As a result, the font in ScummVM is twice as big as it should be. The problem doesn't occur with the English localization since the original font is 320x200. Same thing for every other FM-Towns conversion.

comment:14 by SF/mbandsmer, 16 years ago

I don't think changing VAR_VIDEOMODE to 42 properly fixes this bug, because:

1) The opening credits are worse than before, i.e. the graphics on the edges of the screen display as solid white boxes now.

2) The "flickering light" effects no longer work, e.g., in the woodsmith's shop and the cartographer's shop.

3) The "text shadow" is missing on the "Give", "Pick up", etc, inventory buttons.

I noticed that problems 2 and 3 (as well as the original "purple box" bug) can apparently be fixed by removing the VAR_VIDEOMODE change and then disabling the call to setPalColor() in ScummEngine_v5::o5_roomOps() [case 4]. This makes the inventory/button/conversation colors the same as the FM-Towns original. I've only verified this hackish fix for the first few rooms though, and I also don't know how broadly the fix should apply (to just MI2FM? To all FMTowns games? To just certain palette entries?) This will take a bit of experimenting yet, but if someone with CVS knowledge wants to throw in this change (for all FM-Towns games perhaps?), then more people than just me could test it out.

comment:15 by Kirben, 16 years ago

The VAR_VIDEOMODE change is correct, as I checked disasm. of original game. Although it doesn't seem to help these issues. Disabling o5_roomOps case 4 is just a hack and definately not correct. The code for o5_roomOps case 4 in original game doesn't show any difference, compared to ScummVM.

comment:16 by SF/damaja, 16 years ago

So, can anyone summarize the problem, please? Is it now a bug in ScummVM or MI2 FM-Towns?

comment:17 by fingolfin, 16 years ago

Summary: MI2 FMTOWNS: Purple, Intro CreditsFM-TOWNS MI2: Purple, Intro Credits

comment:18 by Kirben, 15 years ago

Owner: Kirben removed

comment:19 by fingolfin, 15 years ago

The problem with the kanji verbs is "simple" in the sense that I think it's pretty clear what is wrong: the game graphics are being scaled 2x, bug the kanjii verbs are not (so in a sense they are using the same 'overlay-with-higher-resolution' trick which we use for the GUI). In fact from another FM TOWNS bug report we know that for the verb areas they may use another palette (or even 16 bit colors, not sure about that), so it's not a big surprise that wrong colors are used, too.

However, *fixing* this issue is non trivial and would require rather big changes to the SCUMM engine. Personally, I am very reluctant to add such changes. First off I doubt whether it is worth the effort, secondly I do not like adding even more bloat and code complication just for this obscure target. But that is just my personal 2 cents.

comment:20 by fingolfin, 15 years ago

oops, to clarify what I just wrote: I was only referring to the verbs issue, of course.

No idea about the credits; but it is really really really bad that multiple bugs are being covered in this tracker item. The proper way would be to file seperate reports for each of these issues. That will make it much easier for us to properly track and handle these bugs.

comment:21 by SF/joachimeberhard, 15 years ago

The Intro-Bug still is present in the current CVS(09/30/2005).

The Images on the Edges of the Screen are still white Boxes, and the credits are a mess.

I bought this Game in because of ScummVM, and I'm not too happy if you think that this is just an obscure version.

Since I spent a lot of money for it.

Regards

Joachim Eberhard

by fingolfin, 14 years ago

Attachment: mi2fm1.jpg added

Screenshot ScummVM English MI2, first room

by fingolfin, 14 years ago

Attachment: mi2fm2.jpg added

Screenshot ScummVM English MI2, credits

by fingolfin, 14 years ago

Attachment: dumps.zip added

Script dumps

by fingolfin, 14 years ago

Attachment: monkey2fmt_02a.png added

Screenshot Unz Japanese MI2, first room

by fingolfin, 14 years ago

Attachment: monkey2fmt_02b.png added

Screenshot ScummVM Japanese MI2, first room

by fingolfin, 14 years ago

Attachment: monkey2fmt_03.png added

Screenshot ScummVM English MI2, credits

comment:22 by fingolfin, 14 years ago

Summary: FM-TOWNS MI2: Purple, Intro CreditsMI2 FM-TOWNS: Purple, Intro Credits

comment:23 by SF/kaminari, 14 years ago

Old topic, but I thought I'd react nevertheless.

Joachim, spending a lot of money for MI1 FMT and bashing the Team because the game doesn't work as you expected is a very, very bad attitude. A couple years ago, I donated Ender an original copy of Loom TGX in the faint hope that it would help the Team support the game. Time has passed and I strongly doubt it will ever happen (extracting the data has proven to be difficult), but I knew the "risks" before sending my expensive copy, and I don't hold any grudge against them. Maybe you shouldn't either.

You could also buy an FM-Towns or a Marty and learn to live with it <g>

comment:24 by fingolfin, 10 years ago

Florian, is this maybe resolved by your latest changes, too?

comment:25 by fingolfin, 10 years ago

Owner: set to athrxx

comment:26 by athrxx, 10 years ago

Resolution: fixed
Status: newpending

comment:27 by athrxx, 10 years ago

This should be fixed now.

Pleae test again with latest SVN. Be sure to use a build with Hi-Color support (USE_RGB_COLOR). Using old savegames may lead to palette glitches. It would be appreciated if you could play through your Scumm Fm-Towns games again right from the beginning and report any bugs you find.

I set this item to pending.

Florian

comment:28 by SF/sf-robot, 10 years ago

Status: pendingclosed

comment:29 by SF/sf-robot, 10 years ago

This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).

Note: See TracTickets for help on using tickets.