SCUMM: INDY3 (FMTowns): Map lines are drawn incorrectly, plus more issues when leaving Germany

[ATMcashpoint]

In the FM Towns version of Indiana Jones and the Last Crusade, in the original interpreter (both in DREAMM and the UNZ FM Towns interpreter), the red lines on the map screens draw an extra pixel downward and an extra pixel on the right as they go compared to the DOS versions. But ScummVM draws the red lines the same way as it does for DOS.

There are also additional errors with the map screen when leaving Germany. At this point, the game blacks out the Nazi swastika on the flag marking Berlin, and also turns the gray outer parts of the country borders solid black. In ScummVM, when the red line passes over the enlarged black borders, the new black areas disappear right where it passes, revealing sections of the original gray underneath. Also, if you pause the game on the map screen, the added black areas disappear entirely. Neither error is present in the original.

[GermanTribun]

That the borders and flag are overlaid with black is, as far as I know, an error in the FM-Towns version. Since pausing the game makes that go away temporarily, maybe this can be fixed to get rid of the black overlay fully? After all, I see no reason to replicate a behavior that clearly is a bug.

[AndywinXp]

We strive to replicate the original as closely as reasonably achievable, so we will not discard the thing as an original bug and move on. I don't understand your general judgment of what is "clearly" a bug or not, I have to be honest 😛 because this looks like a deliberate choice by the programmers to me, and not some kind of limitation.

[GermanTribun]

OK, if that's the philosophy, I won't argue with you.

[athrxx]

There has been some progress on the ticket. The travel marker is now drawn with the correct width. And the black country borders don't disappear completely when pausing. But they still get
broken by the travel marker and under the pause banner.

[athrxx]

I have now made a complete fix. Please check if it works for you and whether you notice any regressions.

[ATMcashpoint]

Just tested it in the latest ScummVM daily build (May 5, 2024, 6:17:24). Everything seems to match the original behavior now. Thank you so much for fixing this! :D

[gabberhead]

there is a german fanpatched fmtowns version, which i am enhancing with few things since few weeks. in this version, there is a similar problem, but also with a little bit of black letters in the countrynames in german language. but his happends only at the end of the game. in the beginning, there is no problem with the map and the colors and the flag. i played this version few day ago with the latest daily build. i have uploaded a picture of this.

[athrxx]

Please don't re-open an old ticket to report a different issue. If you want someone to write some compensation code for a sloppy fan patch please make a new ticket. The "issue" in this case is known, but fixing bad fan patches isn't really a priority for us.