Opened 16 years ago

Closed 16 years ago

#1450 closed defect (duplicate)

LOOMCD: Subtitles config option is not honored

Reported by: eriktorbjorn Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: script Cc:
Game: Loom

Description

With the current development version of ScummVM, Loom CD does not honor the subtitles option in the config file.

This is because we sync the config setting with the VAR_NOSUBTITLES variable. There are at least three scripts that manipulate this variable, and thus the config setting:

Script 1 sets VAR_NOSUBTITLES to 0 so that the "Please choose your skill level" text is displayed. This is probably necessary, because if I force the subtitles to be disabled at this point it's the "EXPERT" text that's removed when the message times out.

Script 44 sets VAR_NOSUBTITLES to 1. This happens during the first half of the intro, so if you escape the intro early enough you will have subtitles. Otherwise, you won't.

Script 5 handles, among other things, the F9 key which is used to toggle the subtitles. It will both read and write the VAR_NOSUBTITLES variable.

Ticket imported from: #895511. Ticket imported from: bugs/1450.

Change History (3)

comment:1 by Kirben, 16 years ago

There is already a feature request (#752328) for this. One problem is ScummVM can't tell when speech is been used, since music and speech are mixed into CD tracks. So in a few cases (Credits in opening sequence and ending sequence) the subtitles could be disabled when only music is been played. We would need to add a hack to make sure subtitles are always enabled in those two sequences (Along with level selection) and ignore any VAR_NOSUBTITLES changes in scripts at those points.

comment:2 by eriktorbjorn, 16 years ago

Oops, now I remember that you (or was it someone else?) did tell me about that feature request. I had completely forgotten about it. :-)

comment:3 by Kirben, 16 years ago

Owner: set to Kirben
Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.