Quest for Glory III: Wages of War crashes if i press the Enter key in the main menu

[Terelyn]

If i press the Enter key in the main menu, the game crashes and the following message appears in the console. :

ERROR: Uninitialized read for temp 58 from method IconBar::dispatchEvent (room 130, script 937, localCall ffffffff)!

[sluicebox]

Thanks for reporting this. I can reproduce, this is a script bug in the game. I'll take a look soon.

[sluicebox]

Fixed in ​https://github.com/scummvm/scummvm/commit/ab20c9bee27b6afda04e0ab0810a40a573ef8ab5

This will appear in the next daily build.

Thanks again!

[Terelyn]

Replying to sluicebox:

Fixed in ​https://github.com/scummvm/scummvm/commit/ab20c9bee27b6afda04e0ab0810a40a573ef8ab5

This will appear in the next daily build.

Thanks again!

Hi!
Sorry, apperently i only reported the error with the "Restore Game" button. It still crashes the game with different error messages, depending on the selected icon bar when you press Enter.

[sluicebox]

Thanks for trying it out, sounds like we need some more details. First, what version of ScummVM are you using? (or maybe you're building from source?) I ask because my change may not be in the latest daily build yet.

I was able to trip the error before but only once, it doesn't happen every time. You seem to be getting it reliably, can you provide exact instructions on what you're doing with keyboard and mouse to reproduce this? (Starting from launching the game)

Also, which version of QFG3 do you have? It will tell you the version number in the game's control panel when you click the Sierra logo.

[Terelyn]

I'm using the latest daily build of ScummVM. Also steam version of Quest For Glory 3 (DOS).

Okay, i was able reliably reproduce it.

1. Select a button in the main menu with the cursor.
2. Move away the cursor from it sideways, then press Enter.
3. It should crash the game with the exception of "Play Game" "Restore Game" (these work fine) and "Quit" (it doesn't respond, though). It crashes with "Create Character" and "Import Character", too.

The game otherwise works fine.

[sluicebox]

Perfect!

Updated: ​https://github.com/scummvm/scummvm/commit/3e877ab1d8fde0f2d2ef30a52395328ae424badd