Opened 17 years ago

Closed 16 years ago

#1162 closed defect (fixed)

SAM: missing subtitles in Conroy Bumpus' song

Reported by: SF/logicdeluxe Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

ScummVM 0.5.3cvs (Aug 18 2003 12:17:56) I checked with the English and the German version. The song has subtitles with the original interpreter. Load room 47 and enable subtitles to check this out!

Ticket imported from: #790701. Ticket imported from: bugs/1162.

Attachments (1)

samnmax.s12 (9.5 KB ) - added by eriktorbjorn 16 years ago.
Savegame just before visiting Bumpusville

Download all attachments as: .zip

Change History (6)

comment:1 by eriktorbjorn, 16 years ago

I've seen this phenomenon too, but I've never managed to make any sense of it. There are subtitles for the song in the game script, like this:

[01EF] (5D) if (var60 != 0) { [01F9] (B4) print_0_begin() [01FB] (B4) print_0_color(2) [0200] (B4) print_0_center() [0202] (B4) print_0_XY(120,10) [020A] (B4) print_0_msg("I remember my childhood in Brighton") [0232] (73) } else { [0230] (B4) print_0_begin() [0235] (B4) print_0_color(2) [023A] (B4) print_0_center() [023C] (B4) print_0_XY(120,10) [0244] (B4) print_0_msg("I remember my childhood in Brighton") [026A] (A6) drawBox(0,5,280,32,65535) [027A] (**) }

But I don't know what variable 60 signifies, or what it's trying to do with drawBox(). (Is it deliberately trying to erase the subtitles right after they are drawn?)

comment:2 by fingolfin, 16 years ago

Any news on this one? I assume the problem still occurs? If so, a save game would be swell...

Note: var 60 == VAR_NOSUBTITLES (at least in LoomCD). Although in the script snippet erik pasted, var60 != 0 means subtitles ON, and var60==0 means subtitles OFF, so it'd be VAR_SUBTITLES :-).

(For reference: the last parameter of drawBox is the color; if set to -1 (=65535 written as a uint16), it restores the content of the specified screen rect)

comment:3 by eriktorbjorn, 16 years ago

This savegame is a bit old (the only reason it's compressed is that I compressed it manually with gzip), but appears to still work with the latest ScummVM CVS snapshot. It's made just before visiting Bumpusville for the first time, and is for the English talkie version.

by eriktorbjorn, 16 years ago

Attachment: samnmax.s12 added

Savegame just before visiting Bumpusville

comment:4 by Kirben, 16 years ago

Owner: set to Kirben
Resolution: fixed
Status: newclosed

comment:5 by Kirben, 16 years ago

Humongous Entertainment games also used var60 as VAR_NOSUBTITLES, seems odd it seems to be reversed in Sam & Max. There is no reference to var60 in disasm. of Sam & Max, so I assume the developers later changed their minds but accidently left this one check in. I set ScummVM to return config value of subtitles for var60 to order to sovle issue.

Note: See TracTickets for help on using tickets.