Changes between Initial Version and Version 2 of Ticket #15159


Ignore:
Timestamp:
Jun 11, 2024, 4:17:06 PM (5 months ago)
Author:
sluicebox
Comment:

I'm now certain this has nothing to do with MT-32 or any music, so let's ignore all that. It also applies to all versions of this game.

This game has a malformed menu string which has exposed a discrepancy in how we parse malformed menu strings. We display "-Music" because that's the text that this menu string ends in. By luck, Sierra's interpreter ignores the junk "Music" at the end, so the author didn't notice their mistake.

It would be good to fix this, but it's also about as low priority as you can get: this doesn't happen in real games, and the easy solution is to email the author and let them know. I've done that, so presumably this will be fixed in the next game version.

Our menu code is a 200 line function of classic C string parsing. It's also based on reverse engineering, so the names are guesses, meanwhile Here In The Future we know the real spec and the real names of menu string components. Our code also handles dual-language games too. It's risky to alter any of this, and the next game release will make it moot.

It's still worth doing eventually, even if it just makes our menu code a better reference. We'll keep this open, and I'll lower priority and remove the MT-32 references.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15159

    • Property Priority normallow
    • Property Summary SCI: Betrayed Alliance v1.3.2: "Music" in last Speed menu line when MT32 is enabledSCI: Betrayed Alliance - Menu disrepancy: "Music" in Speed menu item
  • Ticket #15159 – Description

    initial v2  
    77Games: Betrayed Alliance v1.3.2: https://github.com/Slattstudio/BetrayedAllianceBook1/releases/tag/release-v1.3.2
    88
    9 Upon being given control in ScummVM with MT-32 emulation enabled, the last entry in the "Speed" menu reads "Slower  -Music". This does not happen in native: the last line instead reads "Slower  -" with the dash properly aligned. See the screenshots for more details. (Native DOS/MT-32 screenshot courtesy of PickledDog.)
     9Upon being given control in ScummVM, the last entry in the "Speed" menu reads "Slower  -Music". This does not happen in native: the last line instead reads "Slower  -" with the dash properly aligned. See the screenshots for more details. (Native DOS screenshot courtesy of PickledDog.)
    1010