Changes between Version 1 and Version 14 of Ticket #13933


Ignore:
Timestamp:
Nov 17, 2022, 12:50:24 AM (18 months ago)
Author:
obskyr
Comment:

Replying to m-kiewitz:

Replying to obskyr:

…Why are you going back and picking out random incidental things to argue against?

That's a major part of ticket description, and I'm just saying that this part is factually wrong and a misunderstanding. That's all. Should probably get removed, it's not even really what this ticket is really about.

Sure. I've changed it to “having been added as of” instead of “added in”.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13933 – Description

    v1 v14  
    11As of some recent version(s), bugs present in the original version of a variety of Sierra games were fixed in ScummVM, making their behavior different from the originals. Following the precedent set by [https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements&oldid=35577 these LucasArts games,] these bug fixes should use the “Enable game-specific enhancements” setting.
    22
    3 I don't know exactly which games are affected, but [https://www.benshoof.org/blog/super-sleuth this blog post] mentions “over one hundred original Sierra bugfixes” being added in version 2.1.0. It's probably possible to find the relevant games and changes by looking at the commits! It seems that most (if not all?) of the changes are in [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be disabled, rather than having to do it per enhancement.
     3I don't know exactly which games are affected, but [https://www.benshoof.org/blog/super-sleuth this blog post] mentions “over one hundred original Sierra bugfixes” having been added as of version 2.1.0. It's probably possible to find the relevant games and changes by looking at the commits! It seems that most (if not all?) of the changes are in [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be disabled, rather than having to do it per enhancement.
    44
    55I've filed this ticket under “Engine: SCI”, but it might affect some AGI games as well.