Opened 22 months ago

Last modified 22 months ago

#13922 closed defect

MacCursor not handling black in color cursors — at Initial Version

Reported by: sluicebox Owned by:
Priority: normal Component: Common
Version: Keywords:
Cc: Game: Quest for Glory 1

Description

Common::MacCursor doesn't handle black in color cursors (crsr resources). Black pixels aren't drawn because they're treated as transparent.

This can be seen in the Run cursor in QFG1VGA-Mac. There are three black pixels, two of which are in the leg, and they're not drawn.

The Mac format allows a full 256 palette plus a separate transparency mask but the Common::Cursor model requires one color to to be the transparency key color. MacCursor is hard-coded to return 0xff as the transparency key but color 0xff is always defined as black in Mac. There is no code that attempts to deal with this and so incoming 0xff pixels aren't drawn.

Change History (1)

by sluicebox, 22 months ago

Note: See TracTickets for help on using tickets.