AGS: Time Gentlemen, Please - random crashes to desktop in the first scene of the game

[antoniou79]

This is on Windows 10 x64. Tested the GOG version with the current daily stable for upcoming 2.6.0 and with a local build of 2.7.0git from master HEAD.

Steps to reproduce:

• Start a new game
• Skip intro cutscenes
• Once you resume control in the first scene, start interacting with objects and the protagonists. Usually (but not always) this happens if you grab Dan and use him on Ben and then try to do something else.

I always got a crash (even after loading into the game to the first scene, but it seems that in that case more actions are needed to cause the crash), but not always after specific interaction so I don't have a deterministic sequence of actions. There's no error message on the console window. The game just exits.

ScummVM log does not offer any help either on this.

Edit:
Trying to quickly debug this with Visual Studio, I got two different unhandled thrown exceptions.

• One was in graphics\surface.cpp, Surface::free() at the first line:

  ::free(pixels);
  

• The other (in a separate play session) was in the destructor of VorbisStream (in audio\decoders\vorbis.cpp):

  VorbisStream::~VorbisStream() {
  	ov_clear(&_ovFile);
  }