Changes between Initial Version and Version 1 of Ticket #13339, comment 1


Ignore:
Timestamp:
Mar 5, 2022, 9:20:31 PM (2 years ago)
Author:
antoniou79

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13339, comment 1

    initial v1  
    66which, for low widths, attempts to create a Rect for which the right x coordinate is lower than the left x coordinate -- and this triggers the assertion fault in the isValidRect() check.
    77
    8 The Game Options "Game" tab has too editable fields, so they are the ones causing the crash.
     8EditTextWidget::getEditRect() is called by EditableWidget::reflowLayout() at [https://github.com/scummvm/scummvm/blob/54240bdac64b5d19c08852180d127faa0789ba0e/gui/widgets/editable.cpp#L62 this line]:
     9
     10{{{
     11        _editScrollOffset = g_gui.getStringWidth(_editString, _font) - getEditRect().width();
     12}}}
     13
     14
     15The Game Options "Game" tab has two editable fields, so they are the ones causing the crash.
    916In very low widths, maybe these fields should not show up at all (just to prevent the crash)?
     17