Opened 16 months ago

Closed 5 months ago

#12504 closed defect (fixed)

ULTIMA8: Master Malchir does not drop the book of 'Tongue of Flames'

Reported by: cefotaxime Owned by: mduggan
Priority: normal Component: Engine: Ultima
Version: Keywords:
Cc: cefotaxime Game: Ultima VIII: Pagan

Description

Master Malchir, when defeated, should drop the book of 'Tongue of Flames' in the original game, which does not happen under the Pentagram or Scummvm engine.

Attachments (3)

K-004.jpg (124.7 KB ) - added by cefotaxime 16 months ago.
ultima8.002 (144.5 KB ) - added by cefotaxime 16 months ago.
Screen Shot 2022-03-25 at 14.06.59.png (59.8 KB ) - added by mduggan 5 months ago.

Download all attachments as: .zip

Change History (10)

by cefotaxime, 16 months ago

Attachment: K-004.jpg added

comment:1 by mduggan, 16 months ago

Thanks for adding the bug. I knew this wasn't working but I hadn't gotten around to investigating. I think that the book is still in a nearby chest so you can still complete the game with this bug, but it's still kind of annoying.

comment:2 by cefotaxime, 16 months ago

Thank you for the prompt interest, mduggan.

The book you've mentioned in a nearby chest is entitled 'The Destruction of the Temple', which is different from the book 'Tongue of Flames'. This book tells the player a vital information that one should go into the big pentagram WITH THE TONGUE OF FLAME(blackrock) to free Pyros. I think this bug should be fixed for the normal walkthrough for this game.

Thanks
Cefotaxime

comment:3 by mduggan, 16 months ago

Thanks for the extra info. I don't think I have a savegame close to that point - do you have a savegame you could attach close to before he attacks you?

Note to myself that treasure data probably needs update.. 041B MALCHIR should probably be drop 0120 GRIMOIRE quality 8 ("The Tongue of Flame").

Version 0, edited 16 months ago by mduggan (next)

by cefotaxime, 16 months ago

Attachment: ultima8.002 added

comment:4 by cefotaxime, 16 months ago

I've uploaded a savegame 'succeeding Malchir'. Enjoy!

comment:5 by digitall, 16 months ago

Keywords: Malchir book Tongue of Flames removed
Summary: Master Malchir does not drop the book of 'Tongue of Flames'ULTIMA8: Master Malchir does not drop the book of 'Tongue of Flames'

comment:6 by mduggan, 5 months ago

I finally got to investigating this a bit more. Some notes:

  • The Tongue of Flame book is created by PYROS::3E82. At offset 46ED it sets the hasTongue global then creates the book.
  • The "traceback" of how this gets spawned is PYROS::3E82 <- FIRE::0080 <- PYROS::247C <- MALCHIR::09F2 ("Come, Acolyte. We must begin the ceremony. ").
  • PYROS::247C can also be spawned from the debug menu (in AVATAR::look)

So it seems like the book is given to him after the ceremony is finished successfully.

I also found one important difference between the original game and our implementation: The original only calls destroyContents on an NPC if they have the FAST_ONLY flag, but we were always destroying contents. This should account for the difference, as Malchir is not FAST_ONLY, but after changing this and using the attached savegame he still doesn't drop the book. In this savegame, he's not carrying the book.

I will have to go back and play through the ceremony to check if that accounts for the difference - once the ceremony is finished he should have it.

Partial fix for this problem was made in 8d9081e7.

Last edited 5 months ago by mduggan (previous) (diff)

comment:7 by mduggan, 5 months ago

Owner: set to mduggan
Resolution: fixed
Status: newclosed

It looks like my change should actually fix things.

From the debug/cheat "Demo" menu on a new game, if I now "Run Pyros" and then go to "Malchir Death", he correctly has the book (see attached screenshot). I think this should fix the bug for a normal playthrough.

Note: See TracTickets for help on using tickets.