Changes between Initial Version and Version 1 of Ticket #11260, comment 1


Ignore:
Timestamp:
Mar 21, 2020, 3:16:10 AM (4 years ago)
Author:
macca8

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11260, comment 1

    initial v1  
    1 Criezy, responding to your request in the Forums for feedback on the PPS OSX v2.1.0 release build.
     1Criezy, responding to your request in the Forums for feedback on the OSX PPC v2.1.0 release build.
    22
    33I’ve tested this version under Rosetta on my Intel iMac running both 10.5 & 10.6. I can confirm that the app performs perfectly on 10.6 (not that that is of any value to a user with a PowerPC Mac), but on 10.5 it behaves exactly as reported above for the Intel Mac daily builds, including the macOS console report.
    44
    5 Out of curiosity, which version of SDL is included in the PPC OSX release build?
     5Out of curiosity, which version of SDL is included in the OSX PPC release build?
    66
    7 May I humbly suggest that we focus on resolving the only bug reported by the maOS console (the Help Menu error for the PPC OSX release & Intel Mac daily builds), then see how the various builds respond.
     7May I humbly suggest that we focus on resolving the only bug reported by the macOS console (the Help Menu error for the OSX PPC release & Intel Mac daily builds), then see how the various builds respond.
    88
    99According to developer.apple.com, and other online sources - including another project that displayed the same selector error on macOS 10.5 - [NSApplication setHelpMenu] is NOT available until macOS 10.6.
    … …  
    4949        [helpMenu release];
    5050
    51 Please note that, as presented, only macosx-compat.h & appmenu_osx.mm need these adjustments. Also, I’ve avoided consolidating any of the code segments (in replaceApplicationMenuItems()) to preserve the existing flow of events in macOS 10.6 & later.
     51Please note that, as presented, only macosx-compat.h & appmenu_osx.mm need adjusting. Also, I’ve avoided consolidating any of the code segments (in replaceApplicationMenuItems()) to preserve the existing flow of events in macOS 10.6 & later.
    5252
    5353I would appreciate your support with this, as I see no downside to making this change. Since you can’t test the changes personally on 10.5, by adding them to master I can at least give you feedback from the developmental build.
    5454Worst case scenario, we’ve eliminated at least one problem.
    5555
    56 I’ve attached copies of both files to clarify the intended changes.
     56I’ve attached copies of both files to clarify the proposed changes.