#2387 closed defect
SCUMM: Bad memory access in filename substitution
| Reported by: | eriktorbjorn | Owned by: | cyxx |
|---|---|---|---|
| Priority: | high | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This happens in the latest CVS snapshot, at least, and has been happening for a while.
In some cases, the generateSubstResFileName_() is called with 'filename' being an empty string. In this case, it will be accessing filename[-1], which could be bad.
I'm not sure exactly when this happens - I'm filing this just so that Eugene won't forget about it - but I'll give two examples of games where it happens for me:
* Monkey Island 1, data files monkey1.000 and monkey1.001. To run this, I use a "monkey1" target.
* The FM-Towns Fate of Atlantis demo. To run this, I use a "atlantisa" target.
Ticket imported from: #1368343. Ticket imported from: bugs/2387.
Change History (6)
comment:1 by , 19 years ago
| Owner: | set to |
|---|
comment:2 by , 18 years ago
comment:3 by , 18 years ago
| Priority: | normal → high |
|---|
comment:4 by , 18 years ago
That should be fixed with latest CVS. I also modified/cleaned up a bit generateSubFilename.
comment:5 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → closed |
comment:6 by , 6 years ago
| Component: | --Unset-- → Engine: SCUMM |
|---|
Note:
See TracTickets
for help on using tickets.
Any news on this?