Opened 2 years ago

Closed 2 years ago

#9977 closed enhancement (fixed)

SCI: PHANT1: Main Menu Cursor Not Red, Initially

Reported by: dafioram Owned by: dafioram
Priority: normal Component: Engine: SCI
Keywords: sci32 Cc:
Game: Phantasmagoria 1

Description

Tester OS: Win7-64
ScummVM: 1.10.0git-3986-gc3f8f1a
Game: Phant1 GOG CD/DOS 1.000.001UK English

Start/load a game then hit quit. The first button you move the cursor over will not turn red. The second button you go to will, even if its the same as the first. The cursor should be red over the buttons in all cases.

This is in the original interpreter.

Demo: https://streamable.com/d7kkg

Change History (4)

comment:1 by csnover, 2 years ago

Priority: lownormal

comment:2 by dafioram, 2 years ago

When quitting and returning to the main menu (room 91) the handle event of User (User.sc/script 64996) User::handleEvent doesn't get trigger when you first hover over a button, but the next time it does. The handleEvent is what sets the cursor and leads to a successful red color draw of the cursor. The main menu is script saveRest.sc so maybe something in there isn't right and thats the handle isn't getting called the first time you pass over the buttons.

comment:3 by dafioram, 2 years ago

A backtrace comparing the two cases (working and with the bug) is given by snover here.

Both enter HotSpot::doit when the mouse is first moved onto the button, but then they diverge, here is the diff of there assembly through HotSpot::doit.

comment:4 by csnover, 2 years ago

Owner: set to dafioram
Resolution: fixed
Status: newclosed

Thanks for your report and your patch! Your patch for this issue has been added in commit ce052fbef4f8f1007c3f64077dbe6d13499d4e7d and will be available in daily builds 1.10.0git-5258 and later.

Note: See TracTickets for help on using tickets.