TITANIC: Incorrect movement locking 2nd and 3rd stars in starfield

[dreammaster]

Despite movement happening when locking in the 2nd and 3rd star, it frequently jumps to an incorrect position rather than starting the movement from the current position. Plus, the end of the movement is occasionally to the wrong position, so that the markers don't fall on the highlighted stars.

[dreammaster]

Bridge

[dafioram]

I believe this bug will be difficult to narrow down since it very often works exactly as it should.

I seen that even before the third star it will often have trouble locking onto the 2nd star.

[dafioram]

Original game. If you lock the 2nd star then unlock and relock it will throw the view to something like this

[dafioram]

In PR997 I have added some code to prevent this situation from happening for 2 stars locking. It still happens for 3 stars, but it doesn't look as bad for 3 stars, since it just misses by a little bit.

Just like in the original not all stars can be used to complete the puzzle and this is no different.

The issue was happening when the player was locking onto a second star and the distances the mover had to move to was > 1e8. This lead to the speeds being large. I suspect the distance from the older to the new position is the same reason for the 3 stars having issues.

[dafioram]

The commit that added the restriction on locking 2 stars for large distances was 2a96a6fc7288a33a3726191338308af3581c9883 (Aug 20).

[dafioram]

Fixed in PR1003.

The game locks correctly for all distances. I've forced the mover (in CStarCamera::lockMarker2) to start where it is going to end up (_mover->transitionBetweenPosOrients(newPos, newPos, oldOr, newOr)) so that it doesn't have to encounter any issues when moving.

I've removed the condition that prevented the lock from being attempted since that was a workaround until this fix.

It does do a pan from the side sometimes, but it always locks.

[dafioram]

Fixed by 4dbfc3595e459a8c51dcdbfada812e525218758f (Aug 31).

[dafioram]

The fix I applied was only when locking onto star2.

After more testing I've observed it for locking onto star3 so the same fix that was done for star2 locking has now been done to star3 in 4e586ba43d9eeff96555be38c89f60209e7ddb0a (Sep 2).