Opened 2 years ago

Closed 2 years ago

#9841 closed defect (wontfix)

SCI: KQ6: No credits music

Reported by: dafioram Owned by: csnover
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: King's Quest 6

Description

ScummVM: 1.10.0git-3379-g8c31328
Tester OS: Win7-64
Game: KQ6 1.000.00G (Kings quest collection) English

After wedding Cassima when the screen says "thank you for playing" it should play some music during the credits and it is just silent.

The closets save I can get is right before attacking Alhazred. So you will have to click through to get through the wedding.

This is the short ending.

Attachments (3)

FailTOC.png (27.6 KB) - added by dafioram 2 years ago.
Status Window (Its the Failed to query...)
kq6-cd-win.077 (42.1 KB) - added by dafioram 2 years ago.
Save during Alhazred final battle. Also my game is cd version no floppy.
NoTrack1.png (34.3 KB) - added by dafioram 2 years ago.
status when cd is in

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by dafioram

Attachment: FailTOC.png added

Status Window (Its the Failed to query...)

Changed 2 years ago by dafioram

Attachment: kq6-cd-win.077 added

Save during Alhazred final battle. Also my game is cd version no floppy.

comment:1 Changed 2 years ago by m-kiewitz

Depending on subtitle/audio settings, the game will try to play CD-Audio.
In case you have not ripped the audio track (Girl in the tower), ScummVM won't be able to play that music.

I'm not sure, if ScummVM is capable of playing the Audio-CD directly.

comment:2 Changed 2 years ago by dafioram

I was unable to find any audio tracks on disc 1 or 2 of the kings quest collection discs. I used windows media player and cdex. They only found data tracks.

First I tried both discs in (separately) while I played the ending and instead of giving me the error it gave me a no track 1 found.

Changed 2 years ago by dafioram

Attachment: NoTrack1.png added

status when cd is in

comment:3 Changed 2 years ago by dafioram

Then I put a misc track01.ogg into the folder and it played the audio, but still gives the "Failed to query the CD TOC: 21" in the status window (see FailTOC.png). So as long as i can get the track it works and now it just reports a disc query error.

Maybe it shouldn't query the disc if it finds the track in the folder? Any idea how many tracks it is looking for? Do you know if the GOG version has the audio tracks?

comment:4 Changed 2 years ago by m-kiewitz

The track is supposed to be called track1.mp3 / .ogg
And I'm not sure if ogg support is built into daily builds, probably it is, but I'm not sure.

comment:5 Changed 2 years ago by csnover

Keywords: sci32 removed

comment:6 Changed 2 years ago by csnover

Owner: set to csnover
Resolution: wontfix
Status: newclosed

Then I put a misc track01.ogg into the folder and it played the audio, but still gives the "Failed to query the CD TOC: 21" in the status window (see FailTOC.png). So as long as i can get the track it works and now it just reports a disc query error.

This is a debugging message, not a warning/error. You may ignore it.

Maybe it shouldn't query the disc if it finds the track in the folder?

Since Win32AudioCDManager::play prefers emulated CD (and so does the MacOSXAudioCDManager), the CD manager code could be changed so that AudioCDManager tries to open the real CD itself in play after emulation fails, instead of right now where users of AudioCDManager must call open themselves before they can call play (and then the result of that open is ignored anyway if emulated files are available). I do not know the reason why open is its own public API. (If it is because the engine is responsible for cleaning up also with close, then I guess SCI is leaking resources right now when CD audio tries to be played…)

Any idea how many tracks it is looking for?

It is not looking for more than one track; querying the CD TOC tells the manager how many tracks are available on the CD.

Do you know if the GOG version has the audio tracks?

It apparently does not.

The track is supposed to be called track1.mp3 / .ogg

Tracks with leading zeroes are supported just fine.

And I'm not sure if ogg support is built into daily builds, probably it is, but I'm not sure.

Yes, it is. (Per the earlier comment, audio from a random track01.ogg played successfully.)

So I will close this ticket now since the root problem is that KQ Collection doesn’t include the CD audio track. If someone wants to have the audio CD manager changed to avoid loading CDs unnecessarily as described above, please go ahead and open a new ticket for that.

Note: See TracTickets for help on using tickets.