Opened 2 years ago

Last modified 12 months ago

#9829 new defect

SQX: The Lost Chapter No sound

Reported by: TarkinMX Owned by:
Priority: normal Component: Engine: AGI
Keywords: Cc:
Game: AGI Fanmade

Description

Tested with the latest stable build and several nightly builds and haven't been able to get any sound.

Change History (8)

comment:1 by darksoul42, 12 months ago

Seconded. I have had this problem for a while now.

comment:2 by digitall, 12 months ago

@darksoul42: Is this a regression? If you test with earlier ScummVM releases i.e. v1.2.0 etc. does this work fine? If so, if you can narrow it down to between two releases, then I can try to bisect and locate the cause (if regression).

comment:3 by darksoul42, 12 months ago

Yes, I also think this is a regression.

I will try narrowing it down in more detail, but if memory serves right:

  • it worked in version 1.7.0, and stopped working, starting with version 1.9.0
  • in 1.9.0 it felt as if the volume was lowered to barely audible levels

comment:4 by darksoul42, 12 months ago

I just backtracked with the older official Ubuntu packages :

  • 1.7.0 :
    ScummVM 1.7.0 (Jul 22 2014 12:00:03)
    Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG
    
    User picked target 'sqx' (gameid 'agi')...
      Looking for a plugin supporting this gameid... AGI preAGI + v2 + v3
      Starting 'Sierra AGI game'
    Emulating Sierra AGI v2.917
    
    • "PC Speaker Emulator" and "MT-32 Emulator" work
  • 1.8.0 :
    ScummVM 1.8.0 (Feb 27 2016 10:23:51)
    Features compiled in: Vorbis MP3 ALSA SEQ TiMidity RGB zLib MPEG2 Theora FreeType2 JPEG PNG
    
    User picked target 'sqx' (gameid 'agi')...
      Looking for a plugin supporting this gameid... AGI preAGI + v2 + v3
      Starting 'Sierra AGI game'
    AGI: Using PC-BIOS font
    Emulating Sierra AGI v2.917
    
    • "PC Speaker Emulator" is mute.
    • "MT-32 Emulator" yields sound, but I have to boost the sound extremely aggressively to even hear something, and there is amplification noise.

Even the latest versions also have the same behavior as 1.8.0.
So if there was a regression, it must have occurred between 1.7.0 and 1.8.0.

comment:5 by digitall, 12 months ago

@darksoul42: Thanks for confirming. Will check and see if I can replicate and narrow down the cause to an exact commit...

comment:6 by digitall, 12 months ago

Right. Have done a bisection. The regression occurs with this commit:

commit a9b25b53d7a7084941553166abd20a602e83e184
Author: Martin Kiewitz <m_kiewitz@users.sourceforge.net>
Date:   Sun Jan 31 22:14:35 2016 +0100

    AGI: properly implement volume control + sync
    
    Original code did assume that AGI volume level is 0-15
    (0 for silence, 15 for maximum volume). It actually is the
    other way. 0 is maximum, 15 is silence.
    Fixed that. Also implemented sync with ScummVM settings dialog.
    In case "mute" is enabled by the user, any volume changes done by
    scripts are ignored.
    Fixes Manhunter 1 Apple IIgs not getting sound anymore since the
    VM Var cleanup (the script volume change by the scripts didn't
    reach us before)

https://github.com/scummvm/scummvm/commit/a9b25b53d7a7084941553166abd20a602e83e184

This may be related to the other bugs which we have had on AGI engine with volume control ...

comment:8 by digitall, 12 months ago

I think the solution to this would be to rework the AGI engine so that the volume for the game sounds stored in ScummVM's config is the _maximum_ volume level available and the volume set by the game scripts scales inside that range i.e. if the ScummVM output volume range is 0 to 255 and is set to for example 100, then the AGI internal volume from scripts of 0 to 16 is mapped to 0 to 100 etc.

Note: See TracTickets for help on using tickets.