Changes between Version 3 and Version 4 of Ticket #9807, comment 5


Ignore:
Timestamp:
07/02/19 23:53:03 (5 years ago)
Author:
angstsmurf

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9807, comment 5

    v3 v4  
    33EDIT: I looked into this. If I add Gabriel Knight Windows version, and then comment out the Windows version from the detection table and rebuild, then the Windows version is still listed in the menu, but when I click on it, it seems to run the DOS version instead (although it uses the engine-specific settings and save files from the Windows version). I guess this is because we re-run detection every time the user starts a game. Perhaps [https://github.com/scummvm/scummvm/pull/1210 PR #1210] will change this?
    44
    5 Still, just removing the detection entries for the Windows version would kind of work already. New users would not be tricked into adding the inferior Windows versions, and old users could still play their games using their old saves, even if some settings might break. In the case of Gabriel Knight 1, for example, the interface will become lo-res with no way to change it back.
     5Still, just removing the detection entries for the Windows version would kind of work already. New users would not be tricked into adding the inferior Windows versions, and old users could still play their games using their old saves, even if some settings might break. In the case of Gabriel Knight 1, for example, the interface will become lo-res with no way to change it back (because it uses the settings of the Windows version, which uses high resolution by default and has no setting for it).
    66
    77EDIT 2: If anyone wants to experiment with this, the lines I commented out are [https://github.com/scummvm/scummvm/blob/master/engines/sci/detection_tables.h#L795-L799 795-799]  in engines/sci/detection_tables.h.