Opened 6 years ago
Closed 3 years ago
#9752 closed defect (fixed)
SCI: Save screenshots blocked by menu
|Reported by:||Kurufinwe21||Owned by:||ZvikaZ|
Steps to reproduce:
- Playing Shivers 1, save your game using the in-game menu.
- Try to restore that save from the ScummVM launcher.
The screenshot associated with the save shows the in-game save menu (with the keyboard), instead of the location at which the save was taken. This renders the screenshots useless, since they all look the same.
I don't know if that can easily be fixed, or if it's worth the bother, but I thought I'd report the issue anyway.
I'm attaching a savegame exhibiting the problem.
ScummVM 1.10.0git3203-g00168003fe (May 1 2017 08:13:02) (win32 daily build from the ScummVM website) running on Windows 10 (64 bit).
Game version: Shivers 1.02 Windows English.
Change History (4)
by , 6 years ago
comment:1 by , 6 years ago
comment:2 by , 6 years ago
|Priority:||normal → low|
|Summary:||SCI: Shivers: Save screenshots show the save menu → SCI: Save screenshots blocked by menu|
Thanks for your report! This is a previously known (though not ticketed) issue.
This problem is actually more widespread than just Shivers 1; QFG4 has the same problem (its screenshots are partially blocked by the settings menu). It is probable that even more SCI32 games have this problem, but I can’t think of more offhand (someone will need to go through all the games to find out).
The problem should be resolvable by making some minor changes to save a screenshot thumbnail before the game’s menu appears, instead of at the moment that a game is actually saved.
There are several possible approaches. Here are two I can think of:
- Modify game scripts (using ScriptPatcher) to notify ScummVM to save/clear a save screenshot before/after the in-game menu appears, perhaps by adding another ScummVM-specific kernel call similar to kernel calls 0xe0 (kScummVMWaitId) and 0xe1 (kScummVMSaveLoadId).
- Monitor the room number or plane list inside the engine, and save/clear a save screenshot before/after the settings/menu plane appears and disappears.
This is a fairly low-complexity, low-priority issue that would be a good first ticket for anyone interested in working on SCI engine.
comment:3 by , 3 years ago
|Status:||new → closed|
Fixed with PR #2053:
savegame with useless screenshot