GUI: Changing 'GUI Language' in Global Options removes theme overlay.
|Reported by:||macca8||Owned by:||criezy|
Platform: Intel Mac (OS X 10.6.8)
Language (OS default): English
This bug has been around since the 'Apply' button was added to the Global Options tabs.
First detected: DB 1.10.0git681-gc32be8e (4 Nov 2016) post-'Apply' button
Last known without bug: DB 1.10.0git509-g7e5842f (24 Oct 2016) pre-'Apply' button
Tested with current Daily Build: 1.10.0git2635-g1a67dee (4 Mch 2017)
Change the 'GUI Language' in the Launcher's 'Options' menu, then click either 'Apply' or 'OK'.
The screen is redrawn without the theme overlay (a black background, with green text, white-outlined rectangular buttons, and a cross cursor… the Launcher menu buttons appear across the bottom of the screen).
On a positive note, the text is changed to the selected language and the relevant buttons remain interactive (though any further changes may cause a crash).
Unfortunately, the only way to restore the Launcher to its normal appearance is to quit ScummVM, then relaunch (making the 'Apply' button redundant in this case).
The expected behaviour of this action, before the 'Apply' button was added, was to display a message to the user advising the need to quit ScummVM to effect the change.
This message no longer appears, so it seems that this bug either (intentionally or otherwise) replaces or overrides the previous behaviour.
Limited testing has revealed that changes to other global options (for example, OpenGL in combination with Fullscreen & Filtering) can also trigger this bug, though not as consistently. Seems that somewhere along the way, one of these actions indirectly changes the 'GUI Language' setting from default to English (in my case), thus priming the bug as previously described.
Just a thought (and I apologise if this is considered off topic), but perhaps it would be prudent to disable the 'Apply' button by default, and only enable it if the selected option doesn't require the user to restart, or exit the tab, to complete the change.