Opened 4 years ago

Closed 8 months ago

Last modified 8 months ago

#9690 closed enhancement (fixed)

SCI: PQ4CD: Needs "dual" audio mode selection

Reported by: csnover Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: sci32 Cc:
Game: Police Quest 4

Description

Like KQ6 and LB2, PQ4CD’s in-game settings only allow toggling between text or speech, instead of allowing both at the same time.

Attachments (1)

speech_text.PNG (2.2 KB ) - added by ZvikaZ 8 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 by csnover, 3 years ago

Priority: lownormal

comment:2 by m-kiewitz, 3 years ago

Now implemented, injected view is missing right now though.
commit bbbbfb6

comment:3 by ZvikaZ, 8 months ago

@m-kiewitz , what do you mean by 'injected view is missing'?
And what is implemented?

Thanks

comment:4 by m-kiewitz, 8 months ago

@ZvikaZ
I patched the game so that people can select "dual" in the game menu.
For this game there is no graphic included saying "dual", so right now there are 3 selections in the game menu called "text", "text" followed by "speech". The first "text" selection is the dual mode, which means text + speech combined, the second "text" is really just that - text only and the 3rd "speech" is well only speech.

What needs to be done is inject such a 3rd graphic into the game. We already do this for SCI 16-bit games, but SCI32 has totally different code for loading these graphics. That code needs to be adjusted too.

by ZvikaZ, 8 months ago

Attachment: speech_text.PNG added

comment:5 by ZvikaZ, 8 months ago

Thanks for your detailed answer.

We're talking about the configuration menu invoked during game play "from inside", right?
I see only SPEECH and TEXT buttons, without a 3rd option. (see my attachment)
With SPEECH it's only speech, but with TEXT is both text and speech.

The "Text and speech" configuration from ScummVM behaves as expected - "Both" gives both of them, "Subtitles" gives only text.

My versions:

ScummVM 2.1.0 (Oct 5 2019 01:07:22)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 FluidSynth Theora AAC A/52 FreeType2 JPEG PNG cloud (servers, local)

PQ4: Aug 12, 1994
Vesrion 1.100.000

comment:6 by m-kiewitz, 8 months ago

Exactly.
When you click on it, you will have to click on it 2 times to get "Speech" enabled.
Without the script patch only 1 click is required. That's because the 3rd "dual" option is hidden in there atm.

comment:7 by bluegr, 8 months ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:8 by m-kiewitz, 8 months ago

Hello md5,
I would have preferred the resource patch to apply to the existing resource. All the SCI16 view patches work that way. It's weird that the resource was patched, but the script patch was not modified accordingly before.
Kind Regards

comment:9 by bluegr, 8 months ago

m-kiewitz: that is a nice enhancement. We got a base patch to work on, so we can change the patched resource and append it to the end of the other view resource. We should use the resource patcher for this, as its functionality will suit us in other cases as well, compared to a hardcoded array of bytes.

comment:10 by m-kiewitz, 8 months ago

bluegr: I don't have a problem with the resource patcher. It's nice to have and should be very useful in certain situations. My issue is with the new view, instead of modifying the already existing view with the resource patcher (unless I'm mistaken on this, but it looks to me like it would add a new view). In my opinion, the "dual" cel should be the 3rd cel of that existing view.

Note: See TracTickets for help on using tickets.