Opened 8 years ago

Closed 5 years ago

#9677 closed feature request (fixed)

SCI: GK2: Subtitle patch doesn't work

Reported by: IntEmu Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: sci32
Cc: Game: Gabriel Knight 2


Hi, I can't get this custom subtitle patch to work in ScummVM.

I installed GK2 for ScummVM by following the ScummVM Datafiles wiki and then manually installed the subtitle patch following the instructions in link below. Then I added 'patchDir = .\SUBPATCH' to RESOURCE.CFG/RESOURCE.WIN.

Also, see this thread, Thank you.

Change History (12)

comment:1 by m-kiewitz, 8 years ago

ScummVM does NOT use resource.cfg nor Both of those are configuration files for the original interpreters.

You could just create a sub-directory called "patches" and put the patch files in there. Or you could just copy them into the main game directory.

Please keep in mind, that we will implement basically the same feature as well (minus the additional subtitles probably), so you won't need all of those files later. And this will work directly and on-the-fly.

Our patch will also support localized versions of the game. And it will also work on different platform versions.

comment:2 by IntEmu, 8 years ago

Hi, renamed '.\SUBPATCH' to '.\PATCHES' and after the 'Chapter One' opening movie ScummVM crashes.

ERROR: Uninitialized read for temp 1 from method ::export 10 (room 34, script 11, loadCall ffffffff)!

Also, using Version 1.0 of the game and please note the author of the patch suggests this patch only works with the Windows version. Thank you.

comment:3 by m-kiewitz, 8 years ago

I will have to look into the script patches.

It seems there is at least one bug inside that fan patch - or maybe a sierra script was modified in a way, that our workarounds do not apply anymore.

ScummVM is checking for quite a few issues like this uninitialized variable error. The original interpreter didn't do that, but such issues may cause other issues down the line.

comment:4 by IntEmu, 8 years ago

Hi, when will ScummVM support GK2 subtitles? How are the subtitles stored? Thank you.

comment:5 by IntEmu, 8 years ago

I mean, you said ScummWM "will implement basically the same feature as well (minus the additional subtitles probably)", when will this feature be available and what do you mean by "minus the additional subtitles"? Thank you.

comment:6 by m-kiewitz, 8 years ago

I can't give you a specific date.
I'm currently trying to figure everything out.

The current subtitle patch is ONLY able to show subtitles and do audio at the same time. You can't switch the subtitles off, at least to my knowledge. And it also seems impossible to run the game in text-only mode.

I'm currently trying to do exactly that. Support text-only. Audio-only and audio+subtitles mode.

But it is complicated and I can't just use the code within the patched scripts.

What I meant with "minus the additional subtitles", is that video subtitles do not exist within the game, but those were added manually by the 2 "hackers" with that patch.

My plan is that you can still add those video subtitles by copying over the .msg files, but we won't patch the game that way automatically, because we would have to add all of those video subtitles inside ScummVM. But you shouldn't need to patch any scripts.

I also already found out that tons of those .scr/.hep files are not needed in any case and those are just 1:1 copies of the scripts used within the game.

I will hopefully also fix the missing inventory audio.

comment:7 by IntEmu, 8 years ago

Hi, thanks for the information, I'm interested in audio+subtitles and can you try to get the patch to work? Thank you.

comment:8 by wjp, 8 years ago

Just to be clear, we don't officially support GK2 at all yet, let alone any additional subtitle patches. Please be patient.

comment:9 by IntEmu, 8 years ago

Hi, with v1.1 of the game and recent daily build, subtitles via ScummVM (rather than the patch) work. Thank you.

comment:10 by m-kiewitz, 8 years ago

I don't see any commit that could have solved it.
Maybe you just got a release-build, which disables all sorts of hard script errors.

The subtitle patch scripts introduce at least one script bug, and that will be found by ScummVM all the time. I also do not want to add a workaround for it and instead patch the scripts properly, so that the user is able to enable/disable subtitles however he/she wants to.

I would also like to keep saved game compatibility. It seems when using the original patched subtitle scripts, old saved games also do not work anymore (at least when using ScummVM).

Please keep bug open for now.

comment:11 by IntEmu, 8 years ago

The subtitle patch on v1.1 of the game still crashes the game and I was mistaken, there are subtitles for audio voice overs if subtitles is selected in ScummVM settings. There are no subtitles for the beginning/end chapter "Movies" nor is there subtitles for in-chapter movies.

comment:12 by sluicebox, 5 years ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Fixed in: 7d4045f4a9c5df7017de4d6bb5cd0871109b0a61

ScummVM is now compatible with the fan-made subtitle patches. I tested both Spanish and English. If there are more out there then I expect them to work too.

The subtitle patches are distributed as installers and I found it easiest to just open the exe with 7-Zip and extract the patch directory myself. Then just copy that into your game directory. If your game directory has a PATCHES directory then copy them there instead. Either way, overwrite any existing patch files with the subtitle patch files.

I am kinda thrilled about this.

Note: See TracTickets for help on using tickets.