Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#965 closed defect (fixed)

music volume slider in F5 menu doesn't work

Reported by: SF/khalek Owned by: lavosspawn
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

latest cvs with Linux The music volume slider moves but doesn't affect the music volume.

Tested with both disk and cd version.

Ticket imported from: #768253. Ticket imported from: bugs/965.

Change History (7)

comment:1 by lavosspawn, 17 years ago

Resolution: fixed
Status: newclosed

comment:2 by joostp, 17 years ago

Owner: set to lavosspawn
Status: closednew

comment:3 by joostp, 17 years ago

Re-opened this because someone on irc (Wishbone) reported that it was broken in the daily build of 11th of July and because both the daily win32 build as well as current CVS segfault for me at startup. (most likely same cause for the bug):

Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 8192 (LWP 2708)] 0x08054908 in SkyAdlibMusic::setVolume(unsigned char) (this=0x8171088, volume=0 '\0') at sky/music/adlibmusic.cpp:55 55 _channels[cnt]->updateVolume(volume | 128);

When commenting out this offending line (+ the corresponding for-loop) the game runs again, but the slider obviously doesn't work anymore either. :)

comment:4 by lavosspawn, 17 years ago

No, those two bugs don't have enything in common. It crashed on your system, joost, because of a bug I newly introduced (volume was set before any section was loaded, so _numberOfChannels wasn't initialized). For wishbone, I bet that he used an old CVS build. I'll leave this bug open to have him verify it, but I'm sure that it works with current CVS.

comment:5 by lavosspawn, 17 years ago

Status: newclosed

comment:6 by SF/wishbone, 17 years ago

No, I did NOT use an old CVS build, not unless noone had updated the daily win32 snapshot in a looong time. I used the snapshot from July 11th, off the download page. If it's possible to get the program to tell me its version/build#, and you can tell me how to do that, I'll be glad to supply it.

Wishbone

comment:7 by fingolfin, 15 years ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.