Opened 4 years ago

Last modified 8 months ago

#9579 new enhancement

SCI: Music volume at zero still plays music very softly

Reported by: csnover Owned by:
Priority: normal Component: Engine: SCI
Keywords: midi Cc:
Game: Space Quest 6

Description

This can be seen in at least SQ6.

Change History (7)

comment:1 by waltervn, 4 years ago

IIRC, this is normal for the ealier games at least. Did you check SQ6 in dosbox?

comment:2 by waltervn, 4 years ago

In SQ3 it does appear that in DOSBox the music actually stops playing if you set volume to 1 (though residual AdLib sounds can still be heard). In ScummVM it keeps playing.

Note: IIRC, the OPL2 velocity control only goes to "very quiet", there's no "off" setting, so you cannot go completely silent by controlling velocity alone.

In any case, I suggest we postpone working on these kinds of issues until the MIDI player has been rewritten. I have a lot of new driver code that has been collecting dust for years, pending this rewrite.

comment:3 by csnover, 4 years ago

IIRC, this is normal for the ealier games at least. Did you check SQ6 in dosbox?

I thought I had, but no, you are right that the same behaviour of non-silent music at volume 0 does occur within SQ6. (Even for non-OPL music devices.) I feel like ScummVM ought to be able to have better control over this, but feel free to close this ticket if you don’t agree.

In any case, I suggest we postpone working on these kinds of issues until the MIDI player has been rewritten. I have a lot of new driver code that has been collecting dust for years, pending this rewrite.

Indeed, I know wjp had also mentioned pending work on rewriting the MIDI code, so this ticket is more of a reminder to check that this is no longer an issue once the rewrite is done, rather than a call to action to fix it in the current MIDI code.

comment:4 by csnover, 3 years ago

Keywords: midi added
Owner: set to csnover

comment:5 by digitall, 2 years ago

Owner: csnover removed

comment:6 by digitall, 23 months ago

Game: Space Quest 6

comment:7 by ZvikaZ, 8 months ago

Type: defectenhancement
Note: See TracTickets for help on using tickets.