Crash when repeatedly going in and out of full screen on OS X

[angstsmurf]

If you repeatedly switch between fullscreen and windowed mode by pressing alt+enter ScummVM will eventually crash with segmentation fault 11. This seems to happen both in OpenGL mode and Normal. Sometimes it will behave erratically and hang in other ways instead. OS X 10.11.6, ScummVM osx_intel-master-b93b8f82.

[criezy]

This is a know issue with SDL 1.2 on recent (and not so recent now) versions of OS X. This was already reported in ticket #6755 so I will close this one as duplicate.

Note: I will provide a 1.9.0 release for OS X compiled with SDL 2, which should hopefully fix this issue. We are starting the release cycle now, so the release should be about a month from now. I am also planning to make available some test builds this weekend (probably tomorrow) and would appreciate if you can test and confirm it fixes the crash.

[angstsmurf]

All right, I assumed that SDL 2 was already default now. I'd be happy to try out a new build.

When compiling myself with SDL 2 I have noticed a problem where the image isn't shrunk along with the window when going from fullscreen to windowed mode, but cut off instead, and that was in fact the bug I was going to report. Then I noticed that it didn't happen in the nightlies, but rather this problem.

[criezy]

I have a OS X 64 bits pre-release version of ScummVM built with SDL2 for testing. It you want to give it a try you can find it here:
​https://www.dropbox.com/s/eqdrmgash7ywexv/scummvm-1.9.0pre-macosx.dmg?dl=0

I did notice the same issue you describe when switching from fullscreen to windowed mode with SDL2. I did not have the time to look at it before today, but it should now be fixed.

And indeed SDL2 should not be the default, but the daily builds from our web site are still built with SDL 1.2.

[angstsmurf]

It works fine now! There is a different issue with reading the keyboard that I'll file separately.