Opened 10 years ago

Closed 10 years ago

Last modified 2 years ago

#9285 closed patch (wontfix)

SCI: prefer MT32 in some older SCI games

Reported by: tsoliman Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: MT-32 MIDI Cc:
Game:

Description

Some SCI games already prefer GM. This makes it so that the rest of them prefer MT32 instead. I tested preferring MT32 falls back gracefully if the MT32 device is "Don't use MT32".

Ticket imported from: #3195866. Ticket imported from: patches/1390.

Attachments (1)

0001-SCI-prefer-MT32-in-some-older-SCI-games.patch (3.9 KB ) - added by tsoliman 10 years ago.
patch against 560eb302f16f2eb

Download all attachments as: .zip

Change History (6)

by tsoliman, 10 years ago

patch against 560eb302f16f2eb

comment:1 by bluegr, 10 years ago

Owner: set to bluegr

comment:2 by bluegr, 10 years ago

Thanks for your patch, however I don't think it is a good idea to prefer MT-32 by default, as that will load up Munt with the default audio settings (unless an actual MT-32 device is present).

I've sent an e-mail to -devel concerning this.

Also, it isn't necessary to drag the device flags around, a check for SCI version can be performed inside the MIDI driver without specifying an additional parameter.

comment:3 by bluegr, 10 years ago

Resolution: wontfix
Status: newclosed

comment:4 by bluegr, 10 years ago

Having discussed this with waltervn and clone2727, it'd be best if the default sound option is Adlib, as that is more compatible and always works. The user is of course able to select any of the MIDI drivers he/she wants, in which case he/she can enjoy GM or MT-32 music.

Therefore, although your work is highly appreciated, this patch is rejected, I'm afraid :(

comment:5 by digitall, 2 years ago

Component: Engine: SCI
Keywords: MT-32 MIDI added
Note: See TracTickets for help on using tickets.