Opened 9 years ago

Closed 5 years ago

Last modified 12 months ago

#9254 closed patch (fixed)

Update wii/gamecube configure

Reported by: SF/wntrmute Owned by: dhewg
Priority: normal Component: Port: Wii
Keywords: Cc:
Game:

Description

This patch updates the configure process for wii/gamecube builds using latest devkitPPC/libogc/libfat

I replaced the old powerpc-gekko host alias with the new powerpc-eabi alias

Under windows devkitPPC uses the TMP environment variable to find the temporary directory used for temp files generated when compiling. The configure script sets this variable during several tests which causes the tests to fail. I've replaced this variable with RES.

strings may not be available on windows if there's no native gcc in the path. Cross gcc provides <prefix>-strings so I've added a check for that in the endianness test.

backends/platform/wii/main.cpp used fatUnmountDefault which doesn't exist in official libfat, I've commented this out for now. I'll need to track down dhewg to see if it should be added.

With latest libogc, KEYBOARD_Init takes a parameter. I've patched this in backends/platform/wii/osystem_events.cpp

backends/platform/wii/wii.mk also needed patched with the new host alias.

Ticket imported from: #3109551. Ticket imported from: patches/1359.

Attachments (1)

scummvm-devkitppc.patch (3.6 KB ) - added by SF/wntrmute 9 years ago.
fixes for compiling with latest devkitPPC under msys on windows

Download all attachments as: .zip

Change History (10)

by SF/wntrmute, 9 years ago

Attachment: scummvm-devkitppc.patch added

fixes for compiling with latest devkitPPC under msys on windows

comment:1 by jvprat, 9 years ago

Owner: set to dhewg

comment:2 by dhewg, 9 years ago

thanks, will look into it. only have to catch up on like 5 or so month of libogc commits ;)

comment:3 by fingolfin, 8 years ago

What is the status of this item?

comment:4 by bluegr, 6 years ago

A more updated version of this is in this pull request:
https://github.com/scummvm/scummvm/pull/413

Keeping this one open in case we want to salvage the changes from it into the pull request changes

comment:5 by digitall, 5 years ago

Have reviewed the patch against the merged code from PR #413.

Of the changes in this patch, the following should be merged:
1. The TMP to RES variable name change in configure looks uncontroversial and should avoid any conflicts in future.
2. The detection for a cross compilation prefixed strings binary for the endian test looks fairly obvious as well, though may need to check that the code there is POSIX standard and not going to cause issues. I think it should be fine, but someone should review.

Other than this all the other changes match those made in the Pull Request (including fatUnmountDefault usage which is now replaced by fatUnmount() calls).

comment:6 by digitall, 5 years ago

Ah tell a lie. bd253a62aca2a0571ad61a3167278d3c5437467a fixes the first of these issues and was integrated by LordHoto in 2011.

comment:7 by digitall, 5 years ago

Have opened the remaining second code block as a Pull Request at:
https://github.com/scummvm/scummvm/pull/463

Will close this patch as fixed/outdated.

comment:8 by digitall, 5 years ago

Resolution: fixed
Status: newclosed

comment:9 by digitall, 12 months ago

Component: Port: Wii
Note: See TracTickets for help on using tickets.