Opened 16 years ago

Closed 8 years ago

#925 closed defect (fixed)

FOA: Music problems in endgame / credits

Reported by: eriktorbjorn Owned by: athrxx
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 4

Description

The latest CVS versions of ScummVM still have problems
with the music towards the end of FOA (English CD version).

Firstly, the music stops prematurely during the end
credits. It's (almost certainly) supposed to play a
medley of themes, starting with the Indy theme, but it
never even starts.

Oddly enough, if I use the debugger to skip straight to
room 96 it works.

Secondly, when using AdLib there are some places where
the instruments sound very distorted. Particularly
during Dr. Ubermann's transformation. (In this case all
of the bad noises are coming from channel 5 by the way.)

Maybe it has something to do with pitchbend? If I
disable the pitchBend() function the bad noises go
away. But why would it make some instruments sound
horrible while most instruments sound just fine? Does
our pitchbend start playing the note all over again at
a different pitch, or does it bend the pitch of the
note while it's playing?

I'm attaching a savegame right before starting the
machine at the end. (The stones are set to their
correct positions already.) I hope that's before any of
the relevant music starts.

Ticket imported from: #761637. Ticket imported from: bugs/925.

Attachments (1)

atlantis.s55.gz (16.0 KB) - added by eriktorbjorn 16 years ago.
Saved game right before endgame

Download all attachments as: .zip

Change History (14)

Changed 16 years ago by eriktorbjorn

Attachment: atlantis.s55.gz added

Saved game right before endgame

comment:1 Changed 16 years ago by eriktorbjorn

Owner: set to SF/jamieson630

comment:2 Changed 16 years ago by eriktorbjorn

Some of the distortion goes away if I lower the volume. I
had cranked up the master- and music volumes to their
maximum settings.

But the worst of it still remains.

comment:3 Changed 16 years ago by SF/jamieson630

Resolution: fixed
Status: newpending

comment:4 Changed 16 years ago by SF/jamieson630

The end credits medley should be fixed in CVS. eriktorbjorn,
please verify. As for the pitch bend distortion, please submit
as a separate bug report. It will take me longer to assess that
issue.

comment:5 Changed 16 years ago by eriktorbjorn

The credits sound fine to me now.

comment:6 Changed 16 years ago by eriktorbjorn

Status: pendingnew

comment:7 Changed 16 years ago by SF/jamieson630

Status: newclosed

comment:8 Changed 8 years ago by athrxx

Owner: changed from SF/jamieson630 to athrxx
Status: closedpending

comment:9 Changed 8 years ago by athrxx

I have reverted that fix since it caused bug #1315950 (https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1315950&group_id=37116) by throwing important 'restart track' commands out of the queue.

Instead, I have added a missing clear_queue() call to stopAllSounds_internal(). This comes from INDY4/MONKEY2 disasm. Could someone with a SAMNMAX or DOTT disasm check whether this is correct for these targets, too?

As I stated in the commit message old INDY4 savegames saved after the Dr. Ubermann death scene (= saved during the ending the sequence) will not work correctly, since the messed up imuse trigger/command queue will be restored from the savegame.

Please test (works for me).

comment:10 Changed 8 years ago by eriktorbjorn

I dug out one of my old savegames (right before the nazis arrive near the end) and played through to the end. I didn't notice any problems with the end credits music.

comment:11 Changed 8 years ago by eriktorbjorn

Status: pendingnew

comment:12 Changed 8 years ago by athrxx

Status: newclosed

comment:13 Changed 8 years ago by athrxx

Thanks for responding so quickly ;-)
The trigger/command queue gets cleared for the last time after Dr. Ubermann becomes a ghost and explodes. Any savegame before that point should be fine.
I'll close this item again.

Note: See TracTickets for help on using tickets.