Opened 10 years ago

Closed 9 years ago

Last modified 13 months ago

#9176 closed patch

BRA: don't corrupt flags when re-entering location

Reported by: fuzzie Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game:

Description

The zone/animation indexes used for restoring flags were out-of-sync with those used for saving, because _zoneProg wasn't incremented when the parser skips zones/anims after the first load.

Ticket imported from: #3004008. Ticket imported from: patches/1281.

Attachments (1)

0001-increment-zone-animation-indexes-even-if-we-re-skipp.patch (1.0 KB ) - added by fuzzie 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by fuzzie, 10 years ago

Owner: set to peres

comment:2 by peres, 10 years ago

Your change looks right, but please make always clear which game/version you are working on.

Since your patch also impact NS, I am going to test if there are any regressions before commit.

comment:3 by fuzzie, 10 years ago

Sorry, I'll try to do that. For clarity: this is a BRA-targeted fix because the _index for zones is BRA-specific, but as you say, _zoneProg is also used to set _prog, which is used for sort order on Gfx objects, so this affects NS.

I'm not familiar enough with NS to test it myself, but I believe the only possible effect would be on preserved anims/zones, which seem to only be special (non-drawn) zones in NS, so I hope there are no regressions.

comment:4 by peres, 9 years ago

Status: newclosed

comment:5 by peres, 9 years ago

Committed in r49428.

comment:6 by digitall, 13 months ago

Component: Engine: Parallaction
Note: See TracTickets for help on using tickets.