Opened 10 years ago

Closed 10 years ago

Last modified 21 months ago

#9166 closed patch (wontfix)

Don't discard all command line options when running GUI

Reported by: SF/rmns Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

The comment in the "base/main.cpp" says

// Discard any command line options. Those that affect the graphics // mode and the others (like bootparam etc.) should not // blindly be passed to the first game launched from the launcher.

but it was discarding them all, so I added a black list which of options should be discarded, I am not so shore how many more should be discarded, so I'm would be grateful for some input.

Ticket imported from: #2986488. Ticket imported from: patches/1271.

Attachments (1)

command_line_options_discard.diff (656 bytes ) - added by SF/rmns 10 years ago.

Download all attachments as: .zip

Change History (5)

by SF/rmns, 10 years ago

comment:1 by fingolfin, 10 years ago

If you are a GSoC student and want this to count, you will have to identify yourself, and register a SourceForge account. Right now you are anonymous, and you'll need an SourceForge account anyway if you are to work with us (indeed, part of the reason we ask for patches via our patch tracker is to ensure you are registered ;).

comment:2 by sev-, 10 years ago

Owner: set to sev-
Resolution: wontfix
Status: newclosed

comment:3 by sev-, 10 years ago

The patch is incomplete, and we need some different approach, as current one will require developers to remember about this spot, come there and add more items to the list.

Rejecting.

comment:4 by digitall, 21 months ago

Component: GUI
Note: See TracTickets for help on using tickets.