Opened 10 years ago

Closed 10 years ago

Last modified 19 months ago

#9165 closed patch

GSoC: MAKEFILE: Fix builds when no engine-data is used

Reported by: SF/dxq Owned by: sev-
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

Currently, several platforms will fail in the final steps of a build if you have opted not to build any engines that require engine data. This is due to lines similar to the following in ports.mk:

cp $(DIST_FILES_ENGINEDATA) $(bundle_name)/Contents/Resources/

Where $DIST_FILES_ENGINEDATA is empty, causing cp to fail (it's only being provided with one argument).

My patch simply adds an ifdef $(DIST_FILES_ENGINEDATA) before the suspect lines.

As far as I can tell, DIST_FILES_ENGINEDATA is the only value that can be left undefined by the configure process that causes this issue.

This patch is against the most current trunk as of writing, r48650.

Ticket imported from: #2986300. Ticket imported from: patches/1270.

Attachments (1)

ports.mk.enginedatafix.patch (1.8 KB ) - added by SF/dxq 10 years ago.

Download all attachments as: .zip

Change History (5)

by SF/dxq, 10 years ago

comment:1 by fingolfin, 10 years ago

Summary: MAKEFILE: Fix builds when no engine-data is usedGSoC: MAKEFILE: Fix builds when no engine-data is used

comment:2 by sev-, 10 years ago

It looks that you did not try to test your patch. Make failed with syntax error.

Though the idea itself seemed to me valuable and I added properly implemented conditionals to our ports.mk.

comment:3 by sev-, 10 years ago

Owner: set to sev-
Status: newclosed

comment:4 by digitall, 19 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.