Opened 11 years ago

Closed 11 years ago

Last modified 2 years ago

#9131 closed patch

Tools: add BS1 mac compression in compress_sword1

Reported by: criezy Owned by: sev-
Priority: normal Component: Tools
Keywords: Cc:
Game: Broken Sword 1

Description

This patch add support for compressing the mac version of BS1 in compress_sword1. It mainly does two things: 1) Add AIFF encoding to mp3/ogg/flac in the CompressionTool class. I have implemented it in that class in case it is needed by other tools, but if you prefer you can move the encodeAIF() function to the CompressSword1 class instead. 2) When using the mac version (it is detected by looking if the music files are AIF or WAV) it uses the same heuristic as the ScummVM sword1 engine to detect if the speech files are little or big endian and pass that to setRawAudioType().

It works fine with my mac version (little endian speech file) but I have no way to check that it also works fine when the speech is in big endian.

Ticket imported from: #2925828. Ticket imported from: patches/1236.

Attachments (1)

compress_bs1_mac.patch (9.9 KB ) - added by criezy 11 years ago.

Download all attachments as: .zip

Change History (5)

by criezy, 11 years ago

Attachment: compress_bs1_mac.patch added

comment:1 by sev-, 11 years ago

Owner: set to sev-
Status: newclosed

comment:2 by sev-, 11 years ago

Excellent! Committed as is. Thank you!

comment:3 by fingolfin, 11 years ago

Is there a reason the method is named encodeAIF() and not extractAndEncodeAIFF ?

comment:4 by digitall, 2 years ago

Component: Tools
Game: Broken Sword 1
Note: See TracTickets for help on using tickets.