Opened 16 years ago

Closed 16 years ago

Last modified 8 months ago

#908 closed defect (fixed)

ALL: cursor pulsates too slow

Reported by: SF/logicdeluxe Owned by: fingolfin
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

ScummVM 0.4.2cvs
Built on Jun 19 2003 11:18:43
With the original interpreters the cursor pulsates
faster. I compared it with the C64, Amiga and PC
versions of Scumm games. On all those systems, the
pulsating is about twice that fast.
I think the faster pulsating looks nicer and should be
done that way in ScummVM, too. Beside this, it would be
closer to the original anyways.

Note that with PC games the cursor flickers a bit with
the original interpreters, which I think is not
supposed to be that way and there is no need to do that
flickering in ScummVM, just the faster pulsating would
be nice.

If you want to check this out, and the flickering on
your PC is too much to even recognise the actual
pulsating, just try some games on C64 and Amiga! Or
also try it with monkeyvga on PC where there is much
less flickering in pause mode.

I think this was from the beginning on since the cursor
works flawless otherwise.

Ticket imported from: #757191. Ticket imported from: bugs/908.

Change History (9)

comment:1 Changed 16 years ago by fingolfin

Priority: normallow

comment:2 Changed 16 years ago by eriktorbjorn

Doubling the speed would be easy. Just change the two lines
in animateCursor() in gfx.cpp that currently are:

if (!(_cursor.animateIndex & 0x3)) {
decompressDefaultCursor((_cursor.animateIndex >>
2) & 3);

to

if (!(_cursor.animateIndex & 1)) {
decompressDefaultCursor((_cursor.animateIndex >>
1) & 3);

I have no idea whether or not this is the correct speed though.

comment:3 Changed 16 years ago by SF/quietust

I get the 'proper' cursor speed (compared to the Amiga
interpreters) by removing the 'slowdown' altogether. That is,
simply doing "decompressDefaultCursor(_cursor.animateIndex
& 3);" and dropping the 'if (!(_cursor.animateIndex &
whatever))' check seems to get the cursor to flash at the
proper speed.
It's possible the Amiga interpreters flash the cursor more
quickly than the PC versions, though...

comment:4 Changed 16 years ago by fingolfin

I doubled the cursor animation speed as per erik's suggestion, and
also did something similar for the GUI cursor. Is that better?

comment:5 Changed 16 years ago by fingolfin

Owner: set to fingolfin
Status: newpending

comment:6 Changed 16 years ago by SF/logicdeluxe

Looks better to me, now.

comment:7 Changed 16 years ago by SF/logicdeluxe

Status: pendingnew

comment:8 Changed 16 years ago by fingolfin

Resolution: fixed
Status: newclosed

comment:9 Changed 8 months ago by digitall

Component: --Unset--Engine: SCUMM
Note: See TracTickets for help on using tickets.