Opened 10 years ago

Closed 10 years ago

Last modified 13 months ago

#9064 closed patch (fixed)

CRUISE: Correct lookup into Spanish font data

Reported by: SF/mac_es Owned by: dreammaster
Priority: normal Component: Engine: Cruise
Keywords: Cc:
Game: Cruise for a Corpse

Description

This patch fixes the bug #2826014

In spanish version when you try to show an extended character it shows the next one. I mean for example instead of 'í' (ascii 161) it shows 'ó' (ascii 162) and so on.

In the bug tracker I thought that 'ñ' character (ascii 164) was correct, but instead of 'ñ' it was showing 'Ñ' (ascii 165) but whith the font they look really similar.

I don't know if this approach is the preferer one, or not. Other approach could be to alter the table...

Ticket imported from: #2831533. Ticket imported from: patches/1169.

Attachments (2)

cruiseFont.patch (683 bytes ) - added by SF/mac_es 10 years ago.
spanish_font_lookup.txt (1.2 KB ) - added by dreammaster 10 years ago.
Suggested font lookup table

Download all attachments as: .zip

Change History (12)

by SF/mac_es, 10 years ago

Attachment: cruiseFont.patch added

comment:1 by dreammaster, 10 years ago

It would be cleaner if I could get you to provide an updated fontCharacterTable - that way I wouldn't have to change any other code specifically for the Spanish version.

by dreammaster, 10 years ago

Attachment: spanish_font_lookup.txt added

Suggested font lookup table

comment:2 by dreammaster, 10 years ago

I've provided a suggested font character table based on your description - if I could get you to confirm it works properly, I'll commit it into the engine

comment:3 by dreammaster, 10 years ago

Owner: set to dreammaster

comment:4 by dreammaster, 10 years ago

As a further point to this issue, I've committed in yet a different version which should be more accurate to your description of the problem - it inserts an extra '-1' at position 128, and removes the old '-1' from position 255.. this should effectively shift upwards all the lookups by one position, and match what the code fragment you provided did.

You can test it in the botbuilds or compile it on your own, to see if it works.

comment:5 by sev-, 10 years ago

Any news? Did that fix the issue for you?

comment:6 by SF/mac_es, 10 years ago

Sorry, I have been on holidays. I will test this asap, today I will post about it.

comment:7 by SF/mac_es, 10 years ago

It works correctly. Thanks

comment:8 by lordhoto, 10 years ago

Can this be closed then?

comment:9 by sev-, 10 years ago

Resolution: fixed
Status: newclosed

comment:10 by digitall, 13 months ago

Component: Engine: Cruise
Game: Cruise for a Corpse
Note: See TracTickets for help on using tickets.