Opened 10 years ago

Closed 10 years ago

Last modified 8 months ago

#9047 closed patch (invalid)

SCI: kgraphics fix for QfG3

Reported by: m-kiewitz Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Quest for Glory 3

Description

Hi there,

This fixes the intro menu in QfG3.

Regards
M. Kiewitz

Ticket imported from: #2819583. Ticket imported from: patches/1152.

Attachments (1)

scummvm-sci-kgraphics.patch (796 bytes) - added by m-kiewitz 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by m-kiewitz

Attachment: scummvm-sci-kgraphics.patch added

comment:1 Changed 10 years ago by m-kiewitz

Note: This seems to give problems in SQ4/SQ5 resulting in text-windows with no text (text gets overwritten by filled box). I guess it's another problem somewhere else or this correction should be game-specific.

comment:2 Changed 10 years ago by m-kiewitz

I just traced it. Fillbox comes first, new button control comes afterwards, so perhaps the drawing is the wrong way round. At least the fix isn't responsible.

comment:3 Changed 10 years ago by bluegr

This code might be more correct than what we have now, but the actual issue is with the current SCI GUI code: it's wrong, and fill boxes are drawn after everything else. With your patch, an old bug re-appears: inventory items are hidden (they're hidden behind the fill box), which is why I put that weird code there. I'm leaving this open for now, till the actual problem is resolved

comment:4 Changed 10 years ago by bluegr

Actually, checking this code again, it seems to be exactly what the commented out code is doing, so that patch is semi-bogus. We need to figure out what the actual problem is and use the commented out code instead. As it is right now, we need to find the actual problem, which lies in the order that widgets and fill boxes are drawn, and not this line, so I'm closing this patch as invalid

comment:5 Changed 10 years ago by bluegr

Owner: set to bluegr
Resolution: invalid
Status: newclosed

comment:6 Changed 8 months ago by digitall

Component: Engine: SCI
Game: Quest for Glory 3
Note: See TracTickets for help on using tickets.