Opened 10 years ago

Closed 10 years ago

Last modified 11 months ago

#9042 closed patch

SCI: resource-view-patch on SQ5/German fix

Reported by: m-kiewitz Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Space Quest 5

Description

Hi there,

I just implemented a quick fix so that SQ5/German doesn't bark about views being not there/invalid. It seems that patch loading is somewhat flawed, perhaps one should take a look at how SCI View does things.

Regards
M. Kiewitz

Ticket imported from: #2819002. Ticket imported from: patches/1147.

Attachments (2)

scummvm-sci-resourcedisassembly.txt (4.8 KB ) - added by m-kiewitz 10 years ago.
Disassembly of SCI View
scummvm-sci-resource.patch (1.2 KB ) - added by m-kiewitz 10 years ago.
New patch

Download all attachments as: .zip

Change History (7)

comment:1 by bluegr, 10 years ago

Hm, this is a hack, and we should actually investigate what's the problem with patch loading. Leaving it open for now, until the real issue is sorted

comment:2 by m-kiewitz, 10 years ago

I just disassembled SCI View. There are several special cases, all occur when header size has bit 7 set. I have done 2 of them (80h and 81h), I don't fully understand the other coding, so that's why I'm leaving it. I hope someone finds a patch file that has that special case in it so ScummVM can support it as well.

ffs.: disassembly attached

by m-kiewitz, 10 years ago

Disassembly of SCI View

by m-kiewitz, 10 years ago

Attachment: scummvm-sci-resource.patch added

New patch

comment:3 by bluegr, 10 years ago

Owner: set to bluegr
Status: newclosed

comment:4 by bluegr, 10 years ago

Thanks for your code :) Applied

comment:5 by digitall, 11 months ago

Component: Engine: SCI
Game: Space Quest 5
Note: See TracTickets for help on using tickets.