Opened 10 years ago

Closed 10 years ago

Last modified 13 months ago

#9040 closed patch

SCI: Timer iterator for audio resources played via doSound

Reported by: m-kiewitz Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game:

Description

Hi there,

Patch that includes new timer iterator, so that SI_FINISHED event gets fired after the audio resource has played via doSound (ffs. scumm-devel)
This fixes SQ4 and possibly many more SCI1 games.

Regards
M. Kiewitz

Ticket imported from: #2818733. Ticket imported from: patches/1145.

Attachments (1)

scummvm-sci-timeriterator.patch (4.5 KB ) - added by m-kiewitz 10 years ago.

Download all attachments as: .zip

Change History (7)

by m-kiewitz, 10 years ago

comment:1 by bluegr, 10 years ago

Just tried your patch but it doesn't fix the desync issue in SQ4CD... i.e. the screen scrolls instantly when the ship takes off :(

comment:2 by m-kiewitz, 10 years ago

Hmm, are we talking about the same sequence? When aborting the intro, you see a mountain and a spaceship flying away. The sound is played, the spaceship is gone and then it will scroll - at least that's what happening on my computer. Try removing the if (delta) return delta; - this should make it scroll sooner - at least it does here.

Also the intro contains zooming on a planet and searching for roger wilco. All this has sounds as well and works as expected.

Regards
M. Kiewitz

comment:3 by bluegr, 10 years ago

Owner: set to bluegr
Status: newclosed

comment:4 by bluegr, 10 years ago

The issue with the scrolling screen is not fixed in SCI4CD, but the intro issues are, as well as an iterator-related crash in SQ4floppy. Therefore applying this. Thanks!

comment:5 by wjp, 10 years ago

I tweaked it slightly in r42385, hopefully fixing the remaining issues.

comment:6 by digitall, 13 months ago

Component: Engine: SCI
Note: See TracTickets for help on using tickets.