Opened 10 years ago

Closed 10 years ago

Last modified 9 months ago

#9032 closed patch

SCI: ReadString fix to repair LSL5 password

Reported by: m-kiewitz Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Leisure Suit Larry 5

Description

Hi there,

Someone replaced readLine with readLine_NEW, but _NEW returns ending LF and ReadString from SCI/FileIO doesn't want that, so LSL5 password gets an extra char, decodes it and instead of NONE it will get NONE(copyright-char). So it wont recognize that password is not set and asks for a password that the user isnt even able to enter :)

This patch fixes it.

Ticket imported from: #2815937. Ticket imported from: patches/1137.

Attachments (1)

scummvm-engine-sci.patch (491 bytes) - added by m-kiewitz 10 years ago.
SCI: FileIO / ReadString fix

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by m-kiewitz

Attachment: scummvm-engine-sci.patch added

SCI: FileIO / ReadString fix

comment:1 Changed 10 years ago by bluegr

Thanks for your patch, it seems that SCI doesn't want the LF char at the end. Applied as-is - this seems to fix the password problems in LSL5 for good

comment:2 Changed 10 years ago by bluegr

Owner: set to bluegr
Status: newclosed

comment:3 Changed 9 months ago by digitall

Component: Engine: SCI
Game: Leisure Suit Larry 5
Note: See TracTickets for help on using tickets.