#9025 closed patch
GP2XWIZ: Basic backend support (derives from SDL backend).
| Reported by: | djwillis | Owned by: | djwillis |
|---|---|---|---|
| Priority: | normal | Component: | Port: GP2XWiz |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Attached is an archive of the /platform/backends/gp2xwiz from the basic GP2XWIZ backend I have been working on.
There are also patches to configure and one change to /platform/backends/sdl/main.cpp (an #ifdef) that I will post diffs for later. I only have a zip of the backend with me and I wanted to get the patch in ASAP to match the alpha test release I made at http://scummvm.distant-earth.com/wp/?p=66.
Built against SVN rev. 41101.
Assuming the code looks reasonable I would like permission to commit and then continue development against SVN rather than locally.
Ticket imported from: #2799862. Ticket imported from: patches/1130.
Attachments (1)
Change History (5)
by , 15 years ago
| Attachment: | gp2xwiz-backend.zip added |
|---|
comment:1 by , 15 years ago
Some remarks: * Please document in the "trick" in module.mk where you include the SDL module.mk * minor point: If I was you, I'd switch from using tons of #defines to enums. Much safer to use (no need to write "0" as "(0)" for example ;) * Why #define TRUE and FALSE instead of using true and false (which as integers have values 1 and 0, by the way, just as your TRUE and FALSE ;)
But overall, the code looks OK to me. Go ahead and commit it, if you like.
comment:2 by , 15 years ago
Committed updated version of this patch addressing most of Fingolfin's comments in 41156.
John
comment:3 by , 15 years ago
| Status: | new → closed |
|---|
comment:4 by , 6 years ago
| Component: | → Port: GP2XWiz |
|---|
Archive of /platform/backends/gp2xwiz